https://bugzilla.gnome.org/show_bug.cgi?id=707129 gtk+ | wayland | unspecified
--- Comment #7 from Kristian Høgsberg <[email protected]> 2013-09-02 21:03:09 UTC --- I think the protocol looks fine, just wondering if it should use a gnome_* prefix instead of gtk_*? Looking at the second patch it looks like all the info comes from inside gtk, so I suppose it's fine. You can drop the %-server-protocol.h makefile rule since this is only client side. Anyway, the wayland side looks fine to me, I defer to Matthias on the gtk+ side of things. ( Just a process nitpick: I wouldn't split this into two patches. The first patch introduces new unused infrastructure, which looks weird, and the next one then makes use of it. My rule of thumb is that it's good to break commits down into logical steps (for bisecting and reivew etc) but for new code/features, I always try to land a complete piece in one commit. ) -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wayland-bugs mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-bugs
