> + if (likely(!blk_should_fake_timeout(req->q)) &&
> + !blk_mq_complete_request_remote(req) &&
> + !blk_mq_add_to_batch(req, iob, vbr->status,
> + virtblk_complete_batch))
One tab indents for line continuations are really confusing. Please
make this:
if (likely(!blk_should_fake_timeout(req->q)) &&
!blk_mq_complete_request_remote(req) &&
!blk_mq_add_to_batch(req, iob, vbr->status,
virtblk_complete_batch))
> + found = virtblk_handle_req(vq, iob);
>
> if (found)
You can drop the found variable here now:
if (virtblk_handle_req(vq, iob))
blk_mq_start_stopped_hw_queues(vblk->disk->queue, true);
Otherwise looks good:
Reviewed-by: Christoph Hellwig <[email protected]>
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
