On Thu, 20 Oct 2022 23:27:33 -0700, [email protected] wrote: > From: Shaoqin Huang <[email protected]> > > Use helper function is_power_of_2() to check if num is power of two. > Minor readability improvement. > > Signed-off-by: Shaoqin Huang <[email protected]>
Reviewed-by: Xuan Zhuo <[email protected]> > --- > drivers/virtio/virtio_pci_modern.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_pci_modern.c > b/drivers/virtio/virtio_pci_modern.c > index c3b9f2761849..207294bd7b9d 100644 > --- a/drivers/virtio/virtio_pci_modern.c > +++ b/drivers/virtio/virtio_pci_modern.c > @@ -310,7 +310,7 @@ static struct virtqueue *setup_vq(struct > virtio_pci_device *vp_dev, > if (!num || vp_modern_get_queue_enable(mdev, index)) > return ERR_PTR(-ENOENT); > > - if (num & (num - 1)) { > + if (!is_power_of_2(num)) { > dev_warn(&vp_dev->pci_dev->dev, "bad queue size %u", num); > return ERR_PTR(-EINVAL); > } > -- > 2.34.1 > > _______________________________________________ > Virtualization mailing list > [email protected] > https://lists.linuxfoundation.org/mailman/listinfo/virtualization _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
