RE: [PATCH] vdpa: allow vdpa dev_del management operation to return failure

Wed, 08 Jun 2022 03:43:54 -0700 


> From: Dawar, Gautam <[email protected]>
> Sent: Wednesday, June 8, 2022 6:30 AM
> To: Jason Wang <[email protected]>
> Cc: netdev <[email protected]>; linux-net-drivers (AMD-Xilinx) <linux-
> [email protected]>; Anand, Harpreet <[email protected]>;
> Michael S. Tsirkin <[email protected]>; Zhu Lingshan
> <[email protected]>; Xie Yongji <[email protected]>; Eli
> Cohen <[email protected]>; Parav Pandit <[email protected]>; Si-Wei Liu <si-
> [email protected]>; Stefano Garzarella <[email protected]>; Wan
> Jiabing <[email protected]>; Dan Carpenter
> <[email protected]>; virtualization <[email protected]
> foundation.org>; linux-kernel <[email protected]>
> Subject: RE: [PATCH] vdpa: allow vdpa dev_del management operation to
> return failure
> 
> [AMD Official Use Only - General]
> 
> Hi Gautam:
> [GD>>] Hi Jason,
> 
> On Fri, Jun 3, 2022 at 6:34 PM Gautam Dawar <[email protected]>
> wrote:
> >
> > Currently, the vdpa_nl_cmd_dev_del_set_doit() implementation allows
> > returning a value to depict the operation status but the return type
> > of dev_del() callback is void. So, any error while deleting the vdpa
> > device in the vdpa parent driver can't be returned to the management
> > layer.
> 
> I wonder under which cognition we can hit an error in dev_del()?
> [GD>>] In the AMD-Xilinx vDPA driver, on receiving vdpa device deletion
> request, I try to identify if the vdpa device is in use by any virtio-net 
> driver
> (through any vdpa bus driver) by looking at the vdpa device status value. In
> case the vdpa device status is >= VIRTIO_CONFIG_S_DRIVER, -EBUSY is
> returned.
> This is to avoid side-effects as noted in
> https://bugzilla.kernel.org/show_bug.cgi?id=213179 caused by deleting the
> vdpa device when it is being used.
> >
User should be able to delete the device anytime.
Upper layers who are unable to perform teardown sequence should be fixed.
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization






















					Reply via email to