On Thu, May 26, 2022 at 10:57:03AM +0200, Eugenio Perez Martin wrote:
On Wed, May 25, 2022 at 1:23 PM Dawar, Gautam <[email protected]> wrote:
[AMD Official Use Only - General]
-----Original Message-----
From: Eugenio Pérez <[email protected]>
Sent: Wednesday, May 25, 2022 4:29 PM
To: Michael S. Tsirkin <[email protected]>; [email protected];
[email protected]; [email protected];
[email protected]; Jason Wang <[email protected]>
Cc: Zhu Lingshan <[email protected]>; [email protected]; Stefano Garzarella <[email protected]>; [email protected]; Eli Cohen
<[email protected]>; Dan Carpenter <[email protected]>; Parav Pandit <[email protected]>; Wu Zongyong
<[email protected]>; [email protected]; Christophe JAILLET <[email protected]>; Xie Yongji
<[email protected]>; Dawar, Gautam <[email protected]>; [email protected]; [email protected]; [email protected]; Longpeng
<[email protected]>; [email protected]; Kamde, Tanuj <[email protected]>; Si-Wei Liu <[email protected]>;
[email protected]; [email protected]; Zhang Min <[email protected]>; [email protected]
Subject: [PATCH v3 2/4] vhost-vdpa: introduce STOP backend feature bit
[CAUTION: External Email]
Userland knows if it can stop the device or not by checking this feature bit.
It's only offered if the vdpa driver backend implements the stop() operation
callback, and try to set it if the backend does not offer that callback is an
error.
Signed-off-by: Eugenio Pérez <[email protected]>
---
drivers/vhost/vdpa.c | 16 +++++++++++++++-
include/uapi/linux/vhost_types.h | 2 ++
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index
1f1d1c425573..32713db5831d 100644
--- a/drivers/vhost/vdpa.c
+++ b/drivers/vhost/vdpa.c
@@ -347,6 +347,14 @@ static long vhost_vdpa_set_config(struct vhost_vdpa *v,
return 0;
}
+static bool vhost_vdpa_can_stop(const struct vhost_vdpa *v) {
+ struct vdpa_device *vdpa = v->vdpa;
+ const struct vdpa_config_ops *ops = vdpa->config;
+
+ return ops->stop;
[GD>>] Would it be better to explicitly return a bool to match the return type?
I'm not sure about the kernel code style regarding that casting. Maybe
it's better to return !!ops->stop here. The macros likely and unlikely
do that.
IIUC `ops->stop` is a function pointer, so what about
return ops->stop != NULL;
Thanks,
Stefano
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
