On Wed, 19 Jan 2022 14:13:39 +0800, Jason Wang <[email protected]> wrote:
> On Wed, Jan 19, 2022 at 10:35 AM Xuan Zhuo <[email protected]> wrote:
> >
> > The virtio spec already supports the virtio queue reset function. This 
> > patch set
> > is to add this function to the kernel. The relevant virtio spec information 
> > is
> > here:
> >
> >     https://github.com/oasis-tcs/virtio-spec/issues/124
> >
> > virtio-net's queue disable/enable function based on virtio queue reset is 
> > here
> >
> >     
> > https://github.com/fengidri/linux/commit/021165b4eda44f87c4b7771ef637bab2512d066f
> >
> > I plan to include this patch in the subsequent virtio-net support AF_XDP
> > patch set.
>
> It's better to send them all to see how the new helpers are actually used.


If this patch is sent together with virtio-net + AF_XDP, I feel that this
patch set will be too big.

I can add the disable/enable function of tx/rx pair to virtio-net. But no one
uses this function for now, so I put it on github.

I'll include these patches for virtio-net using these new helpers in the next 
patch
set.

Thanks.


>
> Thanks
>
> >
> > Also regarding MMIO support for queue reset, I plan to support it after this
> > patch is passed.
> >
> > Please review. Thanks.
> >
> > Xuan Zhuo (6):
> >   virtio: pci: struct virtio_pci_common_cfg add queue_notify_data
> >   virtio: queue_reset: add VIRTIO_F_RING_RESET
> >   virtio: queue_reset: pci: update struct virtio_pci_common_cfg and
> >     option functions
> >   virtio: queue_reset: pci: extract some functions for subsequent
> >     patches
> >   virtio: queue_reset: pci: support VIRTIO_F_RING_RESET
> >   virtio: queue_reset: add helper
> >
> >  drivers/virtio/virtio_pci_common.c     | 140 +++++++++++++++++++------
> >  drivers/virtio/virtio_pci_common.h     |   5 +
> >  drivers/virtio/virtio_pci_modern.c     |  81 ++++++++++++++
> >  drivers/virtio/virtio_pci_modern_dev.c |  28 +++++
> >  include/linux/virtio_config.h          |  78 ++++++++++++++
> >  include/linux/virtio_pci_modern.h      |   2 +
> >  include/uapi/linux/virtio_config.h     |   7 +-
> >  include/uapi/linux/virtio_pci.h        |   2 +
> >  8 files changed, 310 insertions(+), 33 deletions(-)
> >
> > --
> > 2.31.0
> >
>
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Reply via email to