On Mon, 17 Mar 2025, 'John Marriott' via vim_dev wrote:

> On 17-Mar-2025 07:30, Christian Brabandt wrote:
> > patch 9.1.1213: cannot :put while keeping indent
> > 
> > Commit:https://github.com/vim/vim/commit/250739d442b51ba76589d6eb67672d95645527ec
> > Author: 64-bitman<60551350+64-bit...@users.noreply.github.com>
> > Date:   Sun Mar 16 21:10:47 2025 +0100
> > 
> >      patch 9.1.1213: cannot :put while keeping indent
> >      Problem:  cannot :put while keeping indent
> >                (Peter Aronoff)
> >      Solution: add the :iput ex command (64-bitman)
> >      fixes: #16225
> >      closes: #16886
> >      Signed-off-by: 64-bitman<60551350+64-bit...@users.noreply.github.com>
> >      Signed-off-by: Christian Brabandt<c...@256bit.org>
> > 
> After this patch clang (v20.1.0 on Windows 11 Pro) spits out these warnings:
> <snip>
> clang -c -I. -Iproto -DWIN32 -DWINVER=0x0A00 -D_WIN32_WINNT=0x0A00
> -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -D__USE_MINGW_ANSI_STDIO -pipe
> -Wall -O3 -fomit-frame-pointer -fpie -fPIE -Db_lto=true -Db_lto_mode=thin
> -DFEAT_GUI_MSWIN -DFEAT_CLIPBOARD vim9instr.c -o gobjx86-64/vim9instr.o
> vim9instr.c:2544:13: warning: enumeration value 'ISN_IPUT' not handled in
> switch [-Wswitch]
>  2544 |     switch (isn->isn_type)
>       |             ^~~~~~~~~~~~~
> 1 warning generated.
> </snip>
> 
> <snip>
> clang -c -I. -Iproto -DWIN32 -DWINVER=0x0A00 -D_WIN32_WINNT=0x0A00
> -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -D__USE_MINGW_ANSI_STDIO -pipe
> -Wall -O3 -fomit-frame-pointer -fpie -fPIE -Db_lto=true -Db_lto_mode=thin
> -DFEAT_GUI_MSWIN -DFEAT_CLIPBOARD vim9execute.c -o gobjx86-64/vim9execute.o
> vim9execute.c:6002:26: warning: variable 'tv' is uninitialized when used
> here [-Wuninitialized]
>  6002 |                 isn_put_do(ectx, iptr, tv, FALSE);
> |                                        ^~
> vim9execute.c:3327:17: note: initialize the variable 'tv' to silence this
> warning
>  3327 |         typval_T    *tv;
>       |                        ^
>       |                         = NULL
> 1 warning generated.
> </snip>
> 
> About the second warning, line 6005 is almost identical to 6002 but clang
> did not warn about it.

I have reverted it. Sorry I missed the errors in CI. I hope the author 
can fix it.

Thanks,
Christian
-- 
"Summit meetings tend to be like panda matings.  The expectations are always
high, and the results usually disappointing."
                -- Robert Orben

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/vim_dev/Z9c6WO5nnW8fp%2Bck%40256bit.org.

Raspunde prin e-mail lui