patch 9.1.0761: :cd completion fails on Windows with backslash in path Commit: https://github.com/vim/vim/commit/1a31c430bb175144d097ca607dbe10d7960f372a Author: Christian Brabandt <c...@256bit.org> Date: Sun Oct 6 16:34:20 2024 +0200
patch 9.1.0761: :cd completion fails on Windows with backslash in path Problem: :cd completion fails on Windows with backslash in path Solution: switch no_bslash argument to FALSE in file_pat_to_reg_pat() Note: only fixes the problem on Windows. For Unix, we still need to escape backslashes since those are taken as regex atoms (and could be invalid regex atoms). fixes: #15643 closes: #15808 Signed-off-by: Christian Brabandt <c...@256bit.org> diff --git a/src/fileio.c b/src/fileio.c index 5fee4e0be..41e5b5dbf 100644 --- a/src/fileio.c +++ b/src/fileio.c @@ -5570,6 +5570,8 @@ match_file_list(char_u *list, char_u *sfname, char_u *ffname) * allow_dirs, otherwise FALSE is put there -- webb. * Handle backslashes before special characters, like "\*" and "\ ". * + * no_bslash only makes a difference, when BACKSLASH_IN_FILENAME is defined + * * Returns NULL when out of memory. */ char_u * diff --git a/src/findfile.c b/src/findfile.c index 4310a508c..b6ee0920f 100644 --- a/src/findfile.c +++ b/src/findfile.c @@ -2362,7 +2362,7 @@ uniquefy_paths( file_pattern[0] = '*'; file_pattern[1] = NUL; STRCAT(file_pattern, pattern); - pat = file_pat_to_reg_pat(file_pattern, NULL, NULL, TRUE); + pat = file_pat_to_reg_pat(file_pattern, NULL, NULL, FALSE); vim_free(file_pattern); if (pat == NULL) return; diff --git a/src/testdir/test_cmdline.vim b/src/testdir/test_cmdline.vim index 4fec1c1c8..2b392c553 100644 --- a/src/testdir/test_cmdline.vim +++ b/src/testdir/test_cmdline.vim @@ -3920,4 +3920,15 @@ func Test_ex_command_completion() set cpo-=* endfunc +func Test_cd_bslsh_completion_windows() + CheckMSWindows + let save_shellslash = &shellslash + set noshellslash + call system('mkdir XXXa\_b') + defer delete('XXXa', 'rf') + call feedkeys(":cd XXXa\_b\<C-A>\<C-B>\"\<CR>", 'tx') + call assert_equal('"cd XXXa\_b\', @:) + let &shellslash = save_shellslash +endfunc + " vim: shiftwidth=2 sts=2 expandtab diff --git a/src/version.c b/src/version.c index eff0cf824..3b8e7fbe8 100644 --- a/src/version.c +++ b/src/version.c @@ -704,6 +704,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 761, /**/ 760, /**/ -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/E1sxSVL-00G6xj-Co%40256bit.org.