On Sa, 01 Jun 2024, Gary Johnson wrote:

> I would like to request that developers not leave calls to ch_log()
> enabled in released code, that is, in code that has been committed
> to the GitHub repo.
> 
> I just tried debugging some Vim code by sprinkling calls to ch_log()
> in it.  When I ran tail on the log file, I was inundated with log
> messages from other sources, making it hard to find mine.  To quiet
> the log, I put #if 0/#endif around several calls in
> 
>     channel.c
>     evalfunc.c
>     main.c
>     ops.c
>     os_unix.c
>     ui.c
> 
> It would be nice if the responsible developers would fix those in
> the manner they prefer, since the project doesn't seem to have
> a uniform solution for this, such as the one used in term.c.
> 
> Perhaps a note about not leaving calls to ch_log() enabled when
> you're done debugging should be added to src/README.md.

I thought the idea was that you can use `--log file` and have a log with 
all kind of information that can be used even with released versions of 
Vim. So I have used it e.g. to debug what keys are received by Vim when 
a user complains certain keys don't work in alacritty or kitty terminal. 

If we disable the calls to ch_log() we wouldn't be able to debug those, 
no?

Thanks,
Christian
-- 
I believe that the moment is near when by a procedure of active paranoiac
thought, it will be possible to systematize confusion and contribute to the
total discrediting of the world of reality.
                -- Salvador Dali

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/ZlyH0/L2OxNrc/Uo%40256bit.org.

Raspunde prin e-mail lui