On Wed, 18 Mar 2026 19:53:20 GMT, Tobias Hartmann <[email protected]> wrote:
>> Roland Westrelin has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/hotspot/share/runtime/signature.hpp >> >> Co-authored-by: Tobias Hartmann <[email protected]> > > test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestBufferLost.java line 148: > >> 146: >> 147: MemoryMXBean mem = ManagementFactory.getMemoryMXBean(); >> 148: System.out.println("Heap size: " + >> mem.getHeapMemoryUsage().getUsed() / (1024*1024) + " MB"); > > Should we assert some max heap size here? I wondered about that. Isn't there a risk that the test becomes fragile? What would you pick? ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2062#discussion_r2958827062
