On Wed, 18 Mar 2026 14:42:07 GMT, Benoît Maillard <[email protected]> wrote:
> This PR prevents hitting an assert in `vframeArrayElement::fill_in` when > escape analysis and autobox elimination are disabled. > > With value classes, scalarization can take place independently of escape > analysis. When deoptimizing, this implies that we must always rematerialize > objects when `EliminateAllocations` is true, even if escape analysis is > disabled. > Prior to this change, we hit an assert in `vframeArrayElement::fill_in` > because it is expected that scalarized objects are already reallocated there. > We have to make sure that `rematerialize_objects` is run before that. > > ### Testing > - [x] tier1-3, plus some internal testing, with `-XX:-DoEscapeAnalysis > -XX:-EliminateAutoBox` > > Thank you for reviewing! Why was `DoEscapeAnalysis` necessary before, when `EliminateAllocations` is true? ------------- PR Review: https://git.openjdk.org/valhalla/pull/2240#pullrequestreview-3968822700
