Hi everyone, The current naming of the Valhalla-related `markWord` definitions is a bit confusing and does not really match the mainline naming scheme. In particular, the new `*_mask_in_place` constants are not just the corresponding `*_mask` shifted into place. They are instead used as classification masks, so they also include either lock bits or other Valhalla bits.
In this change I tried to make the structure and naming more regular, closer to the pattern we already use in mainline, and also closer to how the non-Valhalla bits are laid out here. I split the definitions into a clearer flow: - Added `*_mask` for all Valhalla fields. - Kept `*_mask_in_place` for the Valhalla fields, but as the shifted version of each corresponding mask. - Added new `*_pattern_mask` constants for the composite masks, to make it clearer that these represent more than a single field mask. This also matches the existing `*_pattern` naming better. As part of this, I updated all uses to the new names that match the intended naming. Overall, this gives the `markWord` bit definitions a more consistent and easier to follow structure. Testing: - Tiers 1-3 ------------- Commit messages: - rename and move valhalla markword masks Changes: https://git.openjdk.org/valhalla/pull/2238/files Webrev: https://webrevs.openjdk.org/?repo=valhalla&pr=2238&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8374147 Stats: 63 lines in 10 files changed: 13 ins; 10 del; 40 mod Patch: https://git.openjdk.org/valhalla/pull/2238.diff Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2238/head:pull/2238 PR: https://git.openjdk.org/valhalla/pull/2238
