On Sat, 14 Mar 2026 01:05:08 GMT, Alex Menkov <[email protected]> wrote:
>> Updated serviceability/jvmti/HeapMonitor/MyPackage/ tests to handle
>> IdentityException to unblock work on throwing IdentityException from
>> NewWeakGlobalRef.
>> It's not yet decided how would be better to update SampledObjectAlloc
>
> Alex Menkov has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - restore empty line
> - use IsValueObject
Can you clarify please exactly what the test code is doing in relation to all
these objects - it is not clear to me what simply ignoring the value objects
implies.
> It's not yet decided how would be better to update SampledObjectAlloc
Is there a JBS issue tracking this?
test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.cpp line
539:
> 537: if (err == JVMTI_ERROR_NONE && count >= 1) {
> 538: if (jni->IsValueObject(object)) {
> 539: // weak references are prohibited for value objects, skip them
Wouldn't it be better to do this upfront before getting the stack trace?
-------------
PR Review:
https://git.openjdk.org/valhalla/pull/2230#pullrequestreview-3951087339
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2230#discussion_r2937793124
