On Thu, 12 Mar 2026 12:44:20 GMT, Christian Hagedorn <[email protected]> 
wrote:

>> Damon Fenacci has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   JDK-8377351: comment
>
> src/hotspot/share/code/aotCodeCache.cpp line 512:
> 
>> 510: 
>> 511:   // The following checks do not affect AOT code, but can disable
>> 512:   // AOT stub/adapters caching if they are incompatible with runtime 
>> settings.
> 
> One additional note: Can you add a comment here why we also need it for 
> adapter caching? This could be surprising when coming from mainline.

Thanks for the review @chhagedorn. I added a sentence.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2217#discussion_r2924519727

Reply via email to