On Wed, 11 Mar 2026 12:36:22 GMT, Frederic Parain <[email protected]> wrote:
>> This patch adds new tests of fields layouts and the substitutability method >> using randomly generated methods. >> In its current form, the value class generator is limited to the JEP 401 >> model, meaning it doesn't support null-restricted fields nor non-atomic >> values. >> >> The value class generator (ValueClassGenerator.java) is used by >> ValueRandomLayoutTest.java which runs the FieldLayoutAnalyzer on all >> generated classes to verify invariants of layouts. >> The value class generator is also used by ValueComparisonTest.java which >> tests the substitutability method. The generated value classes have a set of >> pre-computed values than can be used for instance initializations and value >> comparisons. >> >> Testing in progress tier1-4 >> >> Fred > > Frederic Parain has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 14 additional > commits since the last revision: > > - Fix String replacement and temporary directories creation > - Merge remote-tracking branch 'upstream/lworld' into generated_tests > - Fix generation of short values > - Fix classpath for Windows machines > - Remove hard coded version number > - Refactor generation of primitives pre-generated values > - Fix work directory, identation and other minor fixes > - Fix end of file return and remove dead code > - Test tuning > - Fix layout output > - ... and 4 more: > https://git.openjdk.org/valhalla/compare/8584bda0...b3bacceb Looks good, great work! ------------- Marked as reviewed by phubner (Committer). PR Review: https://git.openjdk.org/valhalla/pull/2202#pullrequestreview-3929738425
