On Mon, 9 Mar 2026 06:16:54 GMT, Axel Boldt-Christmas <[email protected]> 
wrote:

>> For `IS_DEST_UNINITIALIZED` it would never be valid for the 
>> CardTableBarrierSet to do a pre-barrier. Currently `value_copy_in_heap` and 
>> `value_store_null_in_heap` both iterates the oops and virtually calls into 
>> the barriers sets pre barriers (of which all implementations are no-ops for 
>> uninitialized values).
>> 
>> Remove this as part of the `CardTableBarrierSet` interface. After this is 
>> integrated I will upstream the relevant changes of this patch to mainline.
>
> Axel Boldt-Christmas has updated the pull request with a new target base due 
> to a merge or a rebase. The pull request now contains four commits:
> 
>  - Merge remote-tracking branch 'upstream_valhalla/lworld' into JDK-8378521
>  - Update cardTableBarrierSet.inline.hpp
>  - Update cardTableBarrierSet.inline.hpp
>  - 8378521: [lworld] Completely remove pre-barriers in CardTableBarrierSet 
> when IS_DEST_UNINITIALIZED for value stores

Thanks for the review.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/2200#issuecomment-4024165864

Reply via email to