On Mon, 9 Feb 2026 11:07:36 GMT, Stefan Karlsson <[email protected]> wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with one >> additional commit since the last revision: >> >> ZGC Barrier assert to strict > > src/hotspot/share/gc/z/zBarrierSet.inline.hpp line 480: > >> 478: } >> 479: >> 480: void* dst_payload = (void*)(address(dst) + copied_bytes); > > Follow-up: constify locals and consider not having the side-effect of > updating `copied_bytes` in this function. Created [JDK-8378525](https://bugs.openjdk.org/browse/JDK-8378525). > src/hotspot/share/interpreter/interpreterRuntime.cpp line 238: > >> 236: JRT_BLOCK_ENTRY(void, InterpreterRuntime::read_flat_field(JavaThread* >> current, oopDesc* obj, ResolvedFieldEntry* entry)) >> 237: assert(oopDesc::is_oop(obj), "Sanity check"); >> 238: #ifdef ASSERT > > Follow-up: I wonder if this assert could be folded into FlatFieldPayload. Created [JDK-8378519](https://bugs.openjdk.org/browse/JDK-8378519). ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2068#discussion_r2844911242 PR Review Comment: https://git.openjdk.org/valhalla/pull/2068#discussion_r2844913688
