On Wed, 18 Feb 2026 21:20:45 GMT, David Beaumont <[email protected]> wrote:
> Adding a rule to include the value class generated sources into src.zip. > > This is mostly based on work by Christian Stein, which I adapted after > digging through to understand the approach taken in this Make file. > > Since it took me a non-trivial amount of time to fully grok this makefile, I > added a significant amount of documentation for the next person. make/ZipSource.gmk line 106: > 104: ) \ > 105: $(eval SRC_ZIP_SRCS += $$($d_TARGET)) \ > 106: $(eval SRC_ZIP_SRCS_$m += $$($d_TARGET)) \ Note that I am 99.9% sure that the `SRC_ZIP_SRCS_$m` variable being created here is simply never used. I'll probably raise a bug to remove it (here and above) after this is in. For now I'm just copying what's above. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2132#discussion_r2840475562
