On Fri, 20 Feb 2026 21:42:30 GMT, Roger Riggs <[email protected]> wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refactors per comment
>
> src/java.base/share/classes/jdk/internal/value/ValueClass.java line 58:
>
>> 56:
>> 57: /// {@return whether the flat layout for fields of this type
>> contains references}
>> 58: /// Returns true if there is no flat layout for fields of the given
>> type.
>
> Confirming, will return true for an identityClass with only primitive fields?
> The `hasOops` name might need to be more descriptive of the cases for an
> arbitrary class.
No, if there's a field of an identityClass type in another class, that field is
always laid out as a reference.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2143#discussion_r2837165437
