On Thu, 19 Feb 2026 20:15:14 GMT, David Beaumont <[email protected]> wrote:
>> Allow exploded module readers created for exploded system images to support
>> preview mode.
>
> David Beaumont has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review feedback
test/jdk/jdk/internal/jrtfs/ClassResourcesParityTest.java line 74:
> 72: String relPath = jrtClassFile.subpath(2,
> jrtClassFile.getNameCount()).toString();
> 73: String fqn = relPath.substring(0, relPath.length() -
> CLASS_SUFFIX.length()).replace('/', '.');
> 74: String baseName = fqn.substring(fqn.lastIndexOf('.') + 1);
This is fine, just FYI that JAVA_BASE.relativize(jrtClassFile) is another
slicker way to get the relative path from /module/java.base to the resource.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2032#discussion_r2833277850
