[uWSGI] suspicious code in uwsgi_ssl_del_sni_item

[Riccardo Magliocchetti]

Hello,

coverity reports in uwsgi_ssl_del_sni_item, that last_sni cannot be not 
NULL, so should we just remove all occurencies of last_sni?

void uwsgi_ssl_del_sni_item(char *name, uint16_t name_len) {
        struct uwsgi_string_list *usl = NULL, *last_sni = NULL, 
*sni_item = NULL;
        uwsgi_foreach(usl, uwsgi.sni) {
                if (!uwsgi_strncmp(usl->value, usl->len, name, 
name_len) && usl->custom) {
                        sni_item = usl;
                        break;
                }
                last_sni = NULL;
        }

        if (!sni_item) return;

        //  FIXME: this is unreachable
        if (last_sni) {
                last_sni = sni_item->next;
        }
        else {
                uwsgi.sni = sni_item->next;
        }

thanks,
riccardo
_______________________________________________
uWSGI mailing list
uWSGI@lists.unbit.it
http://lists.unbit.it/cgi-bin/mailman/listinfo/uwsgi