Nico Kadel-Garcia wrote on Sun, Apr 29, 2012 at 08:48:27 -0400: > On Sun, Apr 29, 2012 at 1:31 AM, Daniel Shahaf <d...@daniel.shahaf.name>wrote: > > > Nico Kadel-Garcia wrote on Sat, Apr 28, 2012 at 21:38:59 -0400: > > > > > > SKIP and XFAIL are not errors. FAIL are errors. XPASS are not > > supposed > > > > to happen in release tarballs, but if they do they are treated like > > FAIL > > > > is for the purposes of success/failure. The fact that your 'make > > check' > > > > exits non-zero despite having neither FAIL nor XPASS is a bug. > > > > > > > That's what I get for just posting the last few lines. > > > > Recent code prints FAILs after XFAILs and SKIPs, so I can safely say > > that either you didn't have any FAILs or you posted the output of an > > oldish version (1.6.x perhaps?). > > > > 1.6.18, I';m afraid. This is on RHEL 5. Let me post the whole part of the > build where it does the checks: Also note, the "make_check" gut turned off > in the RHEL packages long before I arrived on the schene. The Fedora 17 > packages have the checks enabled, and they can pass on RHEL 6: RHEL 5 and > RHEL 4 both fail. > > Running all tests in utf8_tests.py [55/71]...FAILURE > Running all tests in changes-test [68/71]...success
All the Python tests failed, all the C tests passed. tests.log will have more information. (Though: did it really take one hour? it should take under 10 minutes without the Python tests) You can run % make check TESTS="`echo subversion/tests/cmdline/utf8_tests.py`" or % cd subversion/tests/cmdline && ./utf8_tests.py to skip the C tests (and all-but-one of the Python tests). > At least one test was SKIPPED, checking > /builddir/build/BUILD/subversion-1.6.18/tests.log > SKIP: cache-test 2: basic memcache svn_cache test > SKIP: cache-test 3: memcache svn_cache with very long keys > At least one test XFAILED, checking > /builddir/build/BUILD/subversion-1.6.18/tests.log > XFAIL: fs-test 18: merging commit > XFAIL: locks-test 9: able to reserve a name (lock non-existent path) > XFAIL: locks-test 10: directory locks (kinda) > XFAIL: tree-conflict-data-test 3: detect broken tree conflict data > Summary of test results: > 2 tests SKIPPED > 4 tests XFAILED > make: *** [check] Error 1 > error: Bad exit status from /var/tmp/rpm-tmp.67349 (%check)
