On Wed, Feb 02, 2011 at 03:04:22PM +0000, Neil Bird wrote:
>   I have since compiled up the latest 1.6.x branch, and patched
> svn_io_open_unique_file3() to not call svn_io_open_uniquely_named()
> with 'tempfile.tmp', & instead I cut'n'paste
> svn_io_open_uniquely_named(), replacing the 1-99999 loop with
> 1-MAX_RAND and used the output of rand() in the filename to try.
> 
>   This gave me a few seconds improvement in Linux, and a drastically
> improved 5 minutes in Windows (possibly only now slower as it was
> writing to a network mapped drive).
> 
> 
>   I couldn't use the version from trunk/1.7 as it differs too much.
> I will try to submit the patch for someone's perusal at some point,
> but I couldn't properly test is as for some reason my build of svn
> out of 1.6.x svn (even before modifying it) fails 'make check':  all
> the tests pass, but I get a load of XFAIL lines I don't understand.

Please submit a patch against the 1.6.x branch. I will handle it.

> 
>   AFAICT, the XFAILs I get after my patch are the same as before,
> but it's not the warm PASS feeling I was hoping for.

XFAILs don't matter -- they're expected failures.

Thanks,
Stefan

Reply via email to