'Daniel Shahaf' wrote on Mon, Oct 18, 2010 at 00:24:13 +0200: > Paul Maier wrote on Sun, Oct 17, 2010 at 22:30:23 +0200: > > svn cp svn://...../a b > > should also leave file b as read-write, doesn't it? > > > > Should, but doesn't. >
Fixed in r1023647, using the very same approach I originally (unsuccessfully) tried for the previous patch :-) Thanks for pointing out that the "source is URL to file" and "source is URL to dir" cases should both be tested; in this case, they seem to require separate fixes. > > Or if a whole directory is copied (from wc or from URL) and our file > > is contained somewhere in the depth of that directory? > > > > Agreed, but haven't tested this. This currently fails, presumably somewhere under repos_to_wc_copy_single() -> svn_wc_add4(). I've pinged Julian on IRC, since he was refactoring the latter function recently. (also, at the moment that function isn't exactly the clearest piece of code we have) So there's still work to be done on this part. Daniel
