Hi,
I can't submit a patch via the way recommended on the website.
I tried to send the mail via web interface to de...@rtems.org directly but
then I received something related to spam protection.
It's just a small patch for the arm/stm32h7 bsp which allows to adapt the
clock rate in config.ini for the nucleo board. I also added .project to the
.gitignore files so I can load the rtems soures and browse them in Eclipse.
Is there any other way to submit it or can anyone tell me why I get the
Username/Password reject warning when trying to submit the patch via
command line? I'm sending from a GMAIL account..
Kind Regards
Robin
From 4fbd5f99683518c3442612c639b3894036de8b1e Mon Sep 17 00:00:00 2001
From: "Robin.Mueller" <robin.muelle...@gmail.com>
Date: Wed, 25 Nov 2020 19:53:11 +0100
Subject: [PATCH 1/5] added nucleo adaption
---
This patch introduces a new config.ini option for the arm/stm32h7 bsp, which allows to specify whether the nucleo board is used. If this is set to true, the HSE clock will be set to 8MHz. This was required to have the correct clock configuration for the STM32H743ZI Nucleo board
bsps/arm/stm32h7/include/stm32h7xx_hal_conf.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/bsps/arm/stm32h7/include/stm32h7xx_hal_conf.h b/bsps/arm/stm32h7/include/stm32h7xx_hal_conf.h
index d423e4f782..715a36d807 100644
--- a/bsps/arm/stm32h7/include/stm32h7xx_hal_conf.h
+++ b/bsps/arm/stm32h7/include/stm32h7xx_hal_conf.h
@@ -103,7 +103,9 @@
* (when HSE is used as system clock source, directly or through the PLL).
*/
#if !defined (HSE_VALUE)
-#define HSE_VALUE ((uint32_t)25000000) /*!< Value of the External oscillator in Hz : FPGA case fixed to 60MHZ */
+//#define HSE_VALUE ((uint32_t)25000000) /*!< Value of the External oscillator in Hz : FPGA case fixed to 60MHZ */
+// Correction for the STM32H743ZI Nucleo
+#define HSE_VALUE ((uint32_t)8000000)
#endif /* HSE_VALUE */
#if !defined (HSE_STARTUP_TIMEOUT)
--
2.25.1
From 4e5c1404ce9277eaadd1b7e697310fc97206000f Mon Sep 17 00:00:00 2001
From: "Robin.Mueller" <robin.muelle...@gmail.com>
Date: Wed, 25 Nov 2020 20:16:45 +0100
Subject: [PATCH 2/5] trying to make it externally configurable
---
.gitignore | 1 +
bsps/arm/stm32h7/include/stm32h7xx_hal_conf.h | 8 ++++++--
spec/build/bsps/arm/stm32h7/opth743nucleo.yml | 13 +++++++++++++
3 files changed, 20 insertions(+), 2 deletions(-)
create mode 100644 spec/build/bsps/arm/stm32h7/opth743nucleo.yml
diff --git a/.gitignore b/.gitignore
index 8b28b186e1..ec719d4cf0 100644
--- a/.gitignore
+++ b/.gitignore
@@ -12,3 +12,4 @@ Makefile.in
/testsuites/build/build
/testsuites/build/wscript
.waf*
+.project
diff --git a/bsps/arm/stm32h7/include/stm32h7xx_hal_conf.h b/bsps/arm/stm32h7/include/stm32h7xx_hal_conf.h
index 715a36d807..ff59180d72 100644
--- a/bsps/arm/stm32h7/include/stm32h7xx_hal_conf.h
+++ b/bsps/arm/stm32h7/include/stm32h7xx_hal_conf.h
@@ -103,9 +103,13 @@
* (when HSE is used as system clock source, directly or through the PLL).
*/
#if !defined (HSE_VALUE)
-//#define HSE_VALUE ((uint32_t)25000000) /*!< Value of the External oscillator in Hz : FPGA case fixed to 60MHZ */
+#ifdef STM32H743ZI_NUCLEO
+#define HSE_VALUE ((uint32_t)8000000)
+#else
+#define HSE_VALUE ((uint32_t)25000000) /*!< Value of the External oscillator in Hz : FPGA case fixed to 60MHZ */
+#endif
// Correction for the STM32H743ZI Nucleo
-#define HSE_VALUE ((uint32_t)8000000)
+
#endif /* HSE_VALUE */
#if !defined (HSE_STARTUP_TIMEOUT)
diff --git a/spec/build/bsps/arm/stm32h7/opth743nucleo.yml b/spec/build/bsps/arm/stm32h7/opth743nucleo.yml
new file mode 100644
index 0000000000..3e68455893
--- /dev/null
+++ b/spec/build/bsps/arm/stm32h7/opth743nucleo.yml
@@ -0,0 +1,13 @@
+actions:
+- get-boolean: null
+- define-condition: null
+build-type: option
+default: false
+default-by-variant: []
+enabled-by: true
+format: '{}'
+links: []
+name: STM32H743ZI_NUCLEO
+description: |
+ Nucleo board. Use 8 MHz HSE external clock.
+type: build
--
2.25.1
From ede140e783479c09fc82a0008651e07b612dc488 Mon Sep 17 00:00:00 2001
From: "Robin.Mueller" <robin.muelle...@gmail.com>
Date: Wed, 25 Nov 2020 21:37:31 +0100
Subject: [PATCH 3/5] added build dependency
---
spec/build/bsps/arm/stm32h7/bspstm32h7.yml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/spec/build/bsps/arm/stm32h7/bspstm32h7.yml b/spec/build/bsps/arm/stm32h7/bspstm32h7.yml
index 835247316c..d2573d89fe 100644
--- a/spec/build/bsps/arm/stm32h7/bspstm32h7.yml
+++ b/spec/build/bsps/arm/stm32h7/bspstm32h7.yml
@@ -226,6 +226,8 @@ links:
uid: optmemsdram2sz
- role: build-dependency
uid: optmemsram1sz
+- role: build-dependency
+ uid: opth743nucleo
- role: build-dependency
uid: optmemsram2sz
- role: build-dependency
--
2.25.1
From bd8359bbd7c3d154f401a1ffdf16d90a6e8b34dd Mon Sep 17 00:00:00 2001
From: "Robin.Mueller" <robin.muelle...@gmail.com>
Date: Wed, 25 Nov 2020 21:40:19 +0100
Subject: [PATCH 4/5] moved config option
---
spec/build/bsps/arm/stm32h7/bspstm32h7.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/spec/build/bsps/arm/stm32h7/bspstm32h7.yml b/spec/build/bsps/arm/stm32h7/bspstm32h7.yml
index d2573d89fe..cd3446d1d4 100644
--- a/spec/build/bsps/arm/stm32h7/bspstm32h7.yml
+++ b/spec/build/bsps/arm/stm32h7/bspstm32h7.yml
@@ -226,8 +226,6 @@ links:
uid: optmemsdram2sz
- role: build-dependency
uid: optmemsram1sz
-- role: build-dependency
- uid: opth743nucleo
- role: build-dependency
uid: optmemsram2sz
- role: build-dependency
@@ -246,6 +244,8 @@ links:
uid: ../../optconsolebaud
- role: build-dependency
uid: ../../optconsoleirq
+- role: build-dependency
+ uid: opth743nucleo
- role: build-dependency
uid: ../grp
- role: build-dependency
--
2.25.1
From 706a4542c3bdc963497d6404602dcf24391dea01 Mon Sep 17 00:00:00 2001
From: "Robin.Mueller" <robin.muelle...@gmail.com>
Date: Wed, 25 Nov 2020 23:48:36 +0100
Subject: [PATCH 5/5] comment moved
---
bsps/arm/stm32h7/include/stm32h7xx_hal_conf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bsps/arm/stm32h7/include/stm32h7xx_hal_conf.h b/bsps/arm/stm32h7/include/stm32h7xx_hal_conf.h
index ff59180d72..6c840ed12b 100644
--- a/bsps/arm/stm32h7/include/stm32h7xx_hal_conf.h
+++ b/bsps/arm/stm32h7/include/stm32h7xx_hal_conf.h
@@ -104,11 +104,11 @@
*/
#if !defined (HSE_VALUE)
#ifdef STM32H743ZI_NUCLEO
+// HSE for the STM32H743ZI Nucleo
#define HSE_VALUE ((uint32_t)8000000)
#else
#define HSE_VALUE ((uint32_t)25000000) /*!< Value of the External oscillator in Hz : FPGA case fixed to 60MHZ */
#endif
-// Correction for the STM32H743ZI Nucleo
#endif /* HSE_VALUE */
--
2.25.1
_______________________________________________
users mailing list
users@rtems.org
http://lists.rtems.org/mailman/listinfo/users
