Hi,
after a upgrade from trinidad 1.2.11 to Trinidad 1.2.13 I get a
NullPointerException from one of our monitoring scripts.
Caused by: java.lang.NullPointerException
at
org.apache.myfaces.trinidadinternal.agent.AgentFactoryImpl._populateAgentImpl(AgentFactoryImpl.java:115)
at
org.apache.myfaces.trinidadinternal.agent.AgentFactoryImpl.createAgent(AgentFactoryImpl.java:65)
at
org.apache.myfaces.trinidadinternal.context.RequestContextImpl.getAgent(RequestContextImpl.java:695)
at
org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderKit.chooseRenderKit(CoreRenderKit.java:139)
at
org.apache.myfaces.trinidadinternal.renderkit.CoreRenderKitFactory.getRenderKit(CoreRenderKitFactory.java:52)
While tracking this issue further down it showed that the monitoring script
doesn’t send a User-Agent header along with the request.
This case isn’t considered any more in AgentFactoryImpl._populateAgentImpl().
The version from Trinidad 1.2.11 used to have the following code block:
if (userAgent == null)
{
_populateUnknownAgentImpl(null, agent);
return;
}
This block is missing within the sources of Trinidad 1.2.13.
Is this a bug? Or are there any reasons why this check was dismissed?
Should I file an issue?
Regards
Harald
Harald Kuhn
AirPlus International
Business Information Services
Dornhofstr. 36
63263 Neu-Isenburg
T +49 (0) 61 02. 2 04 - 8 21
F +49 (0) 61 02. 2 04 - 77 8 21
[email protected]<mailto:[email protected]>
www.airplus.com<http://www.airplus.com/>
[cid:[email protected]]
Lufthansa AirPlus Servicekarten GmbH · Hans-Böckler-Straße 7 · 63263
Neu-Isenburg · Germany · Geschäftsführer: Patrick W. Diemer (Vorsitz), Klaus
Busch · Vorsitzender des Aufsichtsrates: Stephan Gemkow · Handelsregister:
Amtsgericht Offenbach/Main, HRB 8119