Thanks for your contribution, Jiaqi!
Wayne
On 2/13/07, Jiaqi Guo <[EMAIL PROTECTED]> wrote:
Thanks Wayne,
Although I found workaround for the tool that I'm working on, the patch
for PluginParameterExpression could be really simple:
sh-3.1$ svn diff
Index:
maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java
===================================================================
---
maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java
(revision 507376)
+++
maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java
(working copy)
@@ -193,6 +193,10 @@
{
value = project.getExecutionProject();
}
+ else if ( "plugin".equals( expression ) )
+ {
+ value = mojoDescriptor.getPluginDescriptor();
+ }
else if ( expression.startsWith( "project" ) )
{
try
So I'll go ahead and create Jira issue with patch.
Maven is always one of my favorite open source projects since it was
under Turbine. I'm very pleased to continue to make contribution.
Regards
-Jiaqi
Wayne Fay wrote:
> Without getting too far into the code myself, you seem to make some
> very good arguments about possible problems in this code. ;-)
>
> I have no idea if this PluginParameterExpressionEvaluator class (and
> the referenced code in Plexus) have proper unit tests etc, but it
> seems like you could make a great contribution in this area if you
> were interested.
>
> Thanks for the comments -- keep it up!
>
> Wayne
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
