Hi Alexander,
Sorry for the delay. Here's the MCVE fork
https://github.com/oracle/kryo/tree/records
I followed your suggestion and moved the compiler config to the relevant
children's poms (pom-main, pom-versioned). Compilation works as expected
now.
To recap: RecordSerializerTest (t) requires jdk 14 --enable-preview for
compilation and test run.
$ mvn clean && mvn install
with jdk-14.0.1 compiles t with --enable-preview and all other tests
without the flag
with jdk-11.0.8 compiles all tests but t Similarly, I tried to set
executions for the test goal to achieve the following: (1) with
jdk-14.0.1 runs t with --enable-preview and all other tests without the
flag
(2) with jdk-11.0.8 runs all tests but t
(2) works fine with the current configuration, but (1) runs *no* tests at all. I
inspected the effective pom and can see that the profile for <jdk11 from the
parent pom is inherited, but I'm not sure if that's the problem.
Again, thanks for your help so far!
Regards,
Julia
On 28/08/2020 04:17, Alexander Kriegisch wrote:
Julia Boes schrieb am 27.08.2020 15:09 (GMT +07:00):
I cannot say for sure, but probably you just copied & pasted my
plugin configurations into the parent POM's <plugin> section instead
of <pluginManagement> -> <plugins>, consequently kicking off test
compilation from the parent. I guess you want to change that.
That's exactly what I did. Moving the configuration to
pluginManagement makes sense, but how would you add profiles to it? Or
would you need to add the profile information in the child poms?
Yes, if you add/override plugin configuration which does not apply to
the whole project but just to some modules, you should add it there.
Just give it a try, I cannot test for you without an MCVE.
BTW, if you can fork the original repo for me and just add enough
commits to reproduce your situation, I can take a closer look.
Currently, I have to speculate based on the information I have, which
is less than ideal.
I know it's not ideal but I can't share a public fork at the moment.
Read again, please. I suggested to fork the *original* Kryo repo and add
just enough Maven config to reproduce the problem. I did not request a
fork of your internal repo.
See also:
https://urldefense.com/v3/__https://stackoverflow.com/help/mcve__;!!GqivPVa7Brio!I33SLOUHJDyw501pJqgBSwasyq6ssvEwjlRRV8KzLHXmYUdFnDHeebMVhPNWw7G5$
--
Alexander Kriegisch
https://urldefense.com/v3/__https://scrum-master.de__;!!GqivPVa7Brio!I33SLOUHJDyw501pJqgBSwasyq6ssvEwjlRRV8KzLHXmYUdFnDHeebMVhFSbdbdO$
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
