that would be awesome. appassembler-m-p should copy the primary jar to its lib directory. However, this also means it must run at package phase in order to see the jar-plugin output
-D On Sat, May 21, 2016 at 1:39 AM, Robert Scholte <[email protected]> wrote: > Hi Dan, > > So if I've correct the appassemble-maven-plugin assumes all jars are > already put in the /lib directory by another plugin. I think it is more > correct to let the plugin pull its libraries to this folder instead. > > WDYT? > Robert > > > > On Fri, 20 May 2016 22:26:45 +0200, Dan Tran <[email protected]> wrote: > > I meant appassemble-maven-plugin. >> >> very likely the error is from the fix of >> https://issues.apache.org/jira/browse/MJAR-198 >> >> For now, I will need to use antrun to copy the local primary jar to the >> place I need. Maybe, appassemble should do this for me >> >> >> btw, if have RPM module but does invocation of 2 jar goals. Would that >> cause an issue? >> >> -D >> >> On Fri, May 20, 2016 at 1:11 PM, Karl Heinz Marbaise <[email protected]> >> wrote: >> >> Hi Dan, >>> On 5/20/16 10:04 PM, Dan Tran wrote: >>> >>> Hi Robert, >>>> >>>> According to the jar plugin source outputDirectory is not read only. >>>> that >>>> is why I can change the default value. >>>> >>>> here is my use case >>>> >>>> - Start out of jar module with a profile to create the RPM >>>> - In the profile, use assembler-maven-plugin to create staging >>>> distribution >>>> >>>> >>> assembly-maven-plugin? Do you mean maven-assembly-plugin ? >>> >>> >>> - since the primary jar file is not in my staging, I need to invoke jar >>> >>>> plugin explicitly to create another jar. This makes jar plugin thinks >>>> it >>>> has 2 primary artifacts and bails out >>>> - Use RPM to package the staging >>>> >>>> >>> As there has been already a call which sets the main artifact (primary >>> artiact) of the project and maven-jar-plugin regrets to set the main >>> artifact if it is already been set.... >>> >>> That sounds like you build needs to be cleaned up...to prevent setting >>> the >>> main artifact twice ? Can we see that build somewhere ? Or can you send >>> me >>> a log file of it? (privately?) >>> >>> >>> >>> This is a valid use case right? >>>> >>>> >>> Hm..we will see.... >>> >>> >>> Kind regards >>> Karl Heinz >>> >>> >>> >>> >>> >>>> Thanks >>>> >>>> -Dan >>>> >>>> >>>> >>>> On Fri, May 20, 2016 at 12:15 PM, Robert Scholte <[email protected]> >>>> wrote: >>>> >>>> Dan, >>>> >>>>> >>>>> outputDirectory has become a readonly parameter. >>>>> The reason is that you can set it with <project><build><directory>. >>>>> Does >>>>> that work for you? >>>>> >>>>> thanks, >>>>> Robert >>>>> >>>>> >>>>> On Fri, 20 May 2016 21:09:55 +0200, Karl Heinz Marbaise < >>>>> [email protected]> >>>>> wrote: >>>>> >>>>> Hi Dan, >>>>> >>>>> >>>>>> On 5/20/16 7:16 AM, Dan Tran wrote: >>>>>> >>>>>> Hi >>>>>> >>>>>>> >>>>>>> My jar project can also create RPM via rpm-maven-plugin:attach-rpm >>>>>>> now >>>>>>> throws this error >>>>>>> >>>>>>> [ERROR] Failed to execute goal >>>>>>> org.apache.maven.plugins:maven-jar-plugin:3.0.0:jar >>>>>>> (project-jar-for-docker) on project xxx: You have to use a classifier >>>>>>> to attach supplemental artifacts to the project instead of replacing >>>>>>> them. -> [Help 1] >>>>>>> >>>>>>> >>>>>>> This is a valid use case where I can have mutiple artifact extensions >>>>>>> without the need to use classifiers >>>>>>> >>>>>>> >>>>>>> Can you create an example project for this? So i can create an JIRA >>>>>> for >>>>>> that or you can create the jira with that...sounds like an edge case >>>>>> which >>>>>> i didn't thought of ?... >>>>>> >>>>>> So you are replacing the main artifact but with different extensions ? >>>>>> >>>>>> Hm.. ? >>>>>> >>>>>> >>>>>> >>>>>> The release notes of jar plugin 3.0.0 also not mentioned about this >>>>>>> >>>>>>> >>>>>>> https://issues.apache.org/jira/browse/MJAR-198 >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> I hope this is not intentional >>>>>>> >>>>>>> >>>>>>> Kind regards >>>>>> Karl Heinz Marbaise >>>>>> >>>>>> --------------------------------------------------------------------- >>>>>> >>>>>> >>>>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>> > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
