Hi Barrie!

Finally, I had some time to checkout the eclipse plugin and do some
modifications to make it work.

If the explicit configuration is not found for the compiler
source/target, it searches for the
maven.compiler.source/maven.compiler.target properties. Even if the
properties are not found, if the compiler plugin version is >= 2.3,
then it defaults to "1.5" (as documented in the maven compiler
plugin).

I attached the patch for the IdeUtils.java class.

Regards,
Gabriel

2011/9/23 Barrie Treloar <[email protected]>:
> On Sat, Sep 24, 2011 at 12:43 AM, Gabriel Belingueres
> <[email protected]> wrote:
>> Thanks Barrie!
>> That modification made the trick.
>>
>> I also don't actually know if configuring the plugin using the command
>> line properties is a best practice.
>> But seeing the source code of the eclipse plugin, I traced it to the
>> IdeUtils.java [1], and it seems that the properties are not tacked
>> into account.
>>
>> [1] 
>> http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/ide/IdeUtils.java
>
> Yup.
> I guess we could take the properties into account, we hard code the
> configuration setting already...
> It would mean that we'd need to look up the property settings for each
> plugin/configuration combination to include the property as well.
>
> Your the first person I'm aware of that has noticed this as a problem.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to