Olivier,
I just took a quick look at the current 1.2-SNAPSHOT and it would
appear that most of the work for this indeed has already been done.
Referring to AbstractRunMojo#createDependencyContexts it seems that there
are a couple of things preventing the configuration I sent in my first post
from actually deploying the war dependency.
- Set<Artifact> artifacts = project.getArtifacts();
- The war must be declared as a dependency in the project's
dependencies element and does not account for plugin dependencies.
- if ( "war".equals( artifact.getType() ) && !artifact.isOptional() &&
filter.include( artifact ) )
- The ScopeArtifactFilter#include call in this line always returns
false so no artifact will ever be deployed.
I guess what I'd like to know is, would it be OK to change this to also look
at the plugin dependencies and to fix the ScopeArtifactFilter or would you
prefer I create a brand new method for pluginDependencies that does
essentially the same thing as the createDependencyContexts method that looks
only at project dependencies?
Thanks in advance for your advice.
-Ryan
On Tue, Jan 11, 2011 at 5:27 PM, Olivier Lamy <[email protected]> wrote:
> Patchs are always welcome :-)
>
> 2011/1/11 Ryan Connolly <[email protected]>:
> > Thanks for the reply, Olivier. I'll give your suggestion a try. Would
> it
> > be worth my time trying to create a patch for this feature or would
> rather
> > just a feature request in JIRA?
> >
> > Thanks again.
> > -Ryan
> > On Jan 11, 2011 5:09 PM, "Olivier Lamy" <[email protected]> wrote:
> >> Hello,
> >> It's not supported currently (btw it's a good idea).
> >> You can use copy goal [1] from dependency plugin to get your artifact
> >> and use deploy-only mojo from t-m-p
> >>
> >>
> >> [1]
> >
> http://maven.apache.org/plugins/maven-dependency-plugin/examples/copying-artifacts.html
> >>
> >> 2011/1/11 Ryan Connolly <[email protected]>:
> >>> Hi:
> >>> Does anyone happen to know whether it is possible to configure
> >>> tomcat:run to deploy a defined war dependency as well as run the
> current
> >>> project as a dynamic web app in the embedded container? I've tried
> > setting
> >>> the <addContextWarDependencies>true</addContextWarDependencies>
> >>> configuration option and have declared a war dependency in the
> tomcat-m-p
> >>> but the dependency does not appear to deploy to the embedded container.
> > Has
> >>> anyone else tried a similar configuration? Any advice would be
> > appreciated.
> >>> An example of what I thought might work follows:
> >>>
> >>> <plugin>
> >>> <groupId>org.codehaus.mojo</groupId>
> >>> <artifactId>tomcat-maven-plugin</artifactId>
> >>> <version>1.1</version>
> >>> <configuration>
> >>> <addContextWarDependencies>true</addContextWarDependencies>
> >>> </configuration>
> >>> <dependencies>
> >>> <dependency>
> >>> <groupId>com.mycompany</groupId>
> >>> <artifactId>war-artifactid</artifactId>
> >>> <version>1.0</version>
> >>> <type>war</type>
> >>> </dependency>
> >>> </dependencies>
> >>> </plugin>
> >>>
> >>>
> >>> Thanks,
> >>> -Ryan
> >>>
> >>
> >>
> >>
> >> --
> >> Olivier Lamy
> >> http://twitter.com/olamy
> >> http://www.linkedin.com/in/olamy
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [email protected]
> >> For additional commands, e-mail: [email protected]
> >>
> >
>
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy
> http://www.linkedin.com/in/olamy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>
