On Thu, 4 Apr 2019 09:41:52 -0700 Joseph Benden <[email protected]> wrote:
> On 4/4/19 8:04 AM, Bernhard Reutner-Fischer wrote: > > On Fri, 22 Mar 2019 at 03:36, Joseph Benden <[email protected]> wrote: > >> This patch ensures all arguments are quoted, during command-line > >> construction. > >> > >> This fixes compilation where spaces occur within the arguments. > > Can you give me an example please? > > g++-uc -DFOO="BAR BAZ" -c ... ? > > > > TIA, > > > Hi, > > Yes. I think we can simply avoid the whole issue. May i ask you to try the attached patch instead? TIA,
diff --git a/bin/Makefile.in b/bin/Makefile.in index 8d11316..9ea2f06 100644 --- a/bin/Makefile.in +++ b/bin/Makefile.in @@ -32,26 +32,20 @@ define do_wrapper $(Q)echo 'WRAPPER_LIBS="$(strip $(LIBS))"' >> [email protected] $(Q)echo '' >> [email protected] $(Q)echo 'WRAPPER_INCLIB="Y"' >> [email protected] - $(Q)echo 'while [ -n "$$1" ]' >> [email protected] + $(Q)echo 'for arg' >> [email protected] $(Q)echo 'do' >> [email protected] - $(Q)echo ' WRAPPER_OPTIONS="$$WRAPPER_OPTIONS $$1"' >> [email protected] - $(Q)echo ' if [ "$$1" = "-c" -o "$$1" = "-E" -o "$$1" = "-S" ]' >> [email protected] - $(Q)echo ' then' >> [email protected] - $(Q)echo ' WRAPPER_INCLIB="N"' >> [email protected] - $(Q)echo ' fi' >> [email protected] - $(Q)echo ' if [ "$$1" = "-static" -a "$$WRAPPER_LIBS" != "$(strip $(STATIC_LIBS))" ]' >> [email protected] - $(Q)echo ' then' >> [email protected] - $(Q)echo ' WRAPPER_LIBS="$(strip $(STATIC_LIBS))"' >> [email protected] - $(Q)echo ' fi' >> [email protected] - $(Q)echo ' shift' >> [email protected] + $(Q)echo ' case "$$arg" in' >> [email protected] + $(Q)echo ' -c|-E|-S) WRAPPER_INCLIB="N" ;;' >> [email protected] + $(Q)echo ' -static) [ "$$WRAPPER_LIBS" != "$(strip $(STATIC_LIBS))" ] && WRAPPER_LIBS="$(strip $(STATIC_LIBS))" ;;' >> [email protected] + $(Q)echo ' esac' >> [email protected] $(Q)echo 'done' >> [email protected] $(Q)echo 'if [ "$$WRAPPER_INCLIB" = "Y" ]' >> [email protected] $(Q)echo 'then' >> [email protected] $(Q)echo ' WRAPPER_OPTIONS="$$WRAPPER_OPTIONS -nodefaultlibs $$WRAPPER_LIBDIR -l$(LNAME) $$WRAPPER_LIBS"' >> [email protected] $(Q)echo 'fi' >> [email protected] $(Q)echo '' >> [email protected] - $(Q)echo '[ -n "$$V" ] && [ $$V -gt 1 ] && echo $(CXX) $(GEN_CFLAGS) $(GEN_CXXFLAGS) $(EH_CXXFLAGS) $$WRAPPER_INCLUDEDIR $$WRAPPER_OPTIONS' >> [email protected] - $(Q)echo 'exec $(CXX) $(GEN_CFLAGS) $(GEN_CXXFLAGS) $(EH_CXXFLAGS) $$WRAPPER_INCLUDEDIR $$WRAPPER_OPTIONS' >> [email protected] + $(Q)echo '[ -n "$$V" ] && [ $$V -gt 1 ] && echo $(CXX) $(GEN_CFLAGS) $(GEN_CXXFLAGS) $(EH_CXXFLAGS) $$WRAPPER_INCLUDEDIR "$$@" $$WRAPPER_OPTIONS' >> [email protected] + $(Q)echo 'exec $(CXX) $(GEN_CFLAGS) $(GEN_CXXFLAGS) $(EH_CXXFLAGS) $$WRAPPER_INCLUDEDIR "$$@" $$WRAPPER_OPTIONS' >> [email protected] $(Q)echo '' >> [email protected] $(Q)chmod 0755 [email protected] $(Q)mv [email protected] $@
_______________________________________________ uClibc mailing list [email protected] http://lists.busybox.net/mailman/listinfo/uclibc
