I believe this would not impact users with those keys working, and it will enable the function of those keys if they did not function in Xorg. The only problem I can currently think of is if the user has remapped F20-F23 for other keys, those keys would not function according to their labels.
The following are the cases I can think of: - If users have the key impacted by this changeset (touchpad toggle/on/off, mic mute) and they were able to use them in Xorg, in noble and oracular they are already mapped to F20-F23 by hwdb, thus not impacted by this patch. - If users have the key impacted by this changeset (touchpad toggle/on/off, mic mute) but they were not able to use them in Xorg, if kernel translated it to the respective key codes correctly [1], this changeset will make the keycode forcibly changed to the F20-F23 so Xorg can receive the input. By convention defined by xkeyboard-settings [2] they are translated to their respective functions. Note that "By convention" part, if a user decided to map F20-F23 for other keys/functions in xkeyboard-config: - If those keys were already working (per above), they would be mapped for what they defined for F20-F23, not functioning according to their labels, this patch does not change the fact. - If those keys were already working and user mapped those keys away from F20-F23 in hwdb, they would also function accordingly. - If those keys were not working and by this patch the keys are mapped to F20-F23, they would be wrongfully function to their mapping for F20-F23 instead of their intended functions. I am wondering whether this is the case you would like to avoid. The problem with the hwdb entry change approach, is that it will begin to deviate from the upstream hwdb and we have to maintain the hacks by ourselves, and the change is per hardware which means we need to tweak each time we have to enable new hardware. [1]: https://github.com/torvalds/linux/blob/f6e0150b2003fb2b9265028a618aa1732b3edc8f/include/uapi/linux/input-event-codes.h#L339 [2]: https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/-/commit/36ec2e08593c9bbbe8a9c9aeba63e8f188efba40 ** Changed in: xserver-xorg-input-libinput (Ubuntu Noble) Status: Incomplete => In Progress ** Changed in: xserver-xorg-input-libinput (Ubuntu Oracular) Status: Incomplete => In Progress -- You received this bug notification because you are a member of Ubuntu-X, which is subscribed to xserver-xorg-input-libinput in Ubuntu. https://bugs.launchpad.net/bugs/2103967 Title: [SRU] Include a patch that forcibly maps mic mute key and touchpad function keys to F20-F23 To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/2103967/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~ubuntu-x-swat Post to : ubuntu-x-swat@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-x-swat More help : https://help.launchpad.net/ListHelp
