Yea, I'll post it. I'll use the image and .c you posted as example. I
dont have a digital camera. I'm guessing there is no other way to take a
screenshot of a usplash...

Also, I tested the fix you submitted with the eft-theme example and I'm pretty 
sure those palette indexes of 342 and 369 are still wrong, when it shows the 
OK/Fail text, the colors keep changing...this behavior isn't intended.
I'm suggesting to keeping them with 0-255, to me it's just a no-brainer, but to 
others it may not be.

The first 2 OK's appear pink.
2nd OK red
3rd OK yellow
4th OK orange
5th OK green
Failed green
6th OK green and turns pink near the end of the test

In theory, all of the OK statuses should display as one color, but as
I've posted above, they dont. I'm guessing it is pointing to memory or
framebuffer thats changing and no error handling to prevent it.

attached is a modified eft-theme and my bash script I use to test with:
The only mod I did is position the text box correctly on the 800x600 res. It's 
pretty bad when the example usplash can't even position the text box in the 
right spot :/ In my opinion, the Example theme should be updated and I would 
consider it very important as anyone wanting to make their own is going to 
start there.

My suggestion is to change your 'text success' from 369 to 49 to match
'text foreground', and to change 'text failure' to '44', the 'progress
foreground' to 156.

As I stated above, I think this fix needs to be merged, but not before
the palette indexes are corrected so that they aren't higher than the
number of colors.

To Colin: I haven't looked at the actual usplash code that these values
point to but there shouldn't be any reason why anything larger than a
short integer is needed since we are confined to 256 colors.



** Attachment added: "eft-theme.c"
   http://launchpadlibrarian.net/16719295/eft-theme.c

-- 
palette indexes in eft-theme.c should not be prefixed with 0x
https://bugs.launchpad.net/bugs/66760
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to