I think checking /etc/lsb-release for the name of the distribution may
be more appropriate than a straight text patch.  This way the patch
could be used upstream and we'd avoid a difference between the Debian
and Ubuntu versions.

I also spotted a minor typo in the usage message text which I corrected,
and I updated the Standards-Version to keep lintian happy :-)

I'll attach a .debdiff.  For some reason dch created a ubuntu-specific
version for me... anyway, here it is.

The patch becomes:

diff -Nru apticron-1.1.20/apticron apticron-1.1.20ubuntu1/apticron
--- apticron-1.1.20/apticron    2006-10-25 15:36:17.000000000 -0700
+++ apticron-1.1.20ubuntu1/apticron     2008-07-22 20:40:23.000000000 -0700
@@ -2,7 +2,7 @@
 
 if [ -n "$1" ]; then
        echo "Usage: apticron"
-       echo "Mails a list of packaged that are pending-upgrade to the"
+       echo "Mails a list of packages that are pending-upgrade to the"
        echo "email address specified in /etc/apticron/apticron.conf"
        exit 1
 fi     
@@ -22,6 +22,10 @@
 # Set the IPADDRESSNUM
 IPADDRESSNUM="1"
 
+# Source lsb-release to so we know what distribution we are
+DISTRIB_ID="Debian"    # Default to Debian
+[ -e /etc/lsb-release ] && . /etc/lsb-release
+
 # Source the config file
 [ -e /etc/apticron/apticron.conf ] && . /etc/apticron/apticron.conf
 
@@ -132,6 +136,6 @@
 apticron
 EOF
 
-   ) 2>&1 | /usr/bin/mailx -s "Debian package updates on `/bin/hostname`" 
$EMAIL
+   ) 2>&1 | /usr/bin/mailx -s "$DISTRIB_ID package updates on `/bin/hostname`" 
$EMAIL
 
 fi

Jonathan

** Attachment added: "apticron_1.1.20ubuntu1.debdiff"
   http://launchpadlibrarian.net/16246174/apticron_1.1.20ubuntu1.debdiff

-- 
apticron should refer to Ubuntu instead of Debian in mail subject
https://bugs.launchpad.net/bugs/78357
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to