@Steve: looking close, some smallish issues: a) i) I think you should drop the .git when repacking; upstream shouldn't actually include these in released tarball, but they don't actually roll "release tarballs"; I even think it's an artefact of the way the tarballs are created by their archive software. (Upstream could also git repack from time to time as dealing with 584 files or so is a bit inefficient.) So not your fault (upstream should release proper tarballs), but stripping of CVS/, .svn/, or .git/ dirs is usually addressed by Debian / Ubuntu maintainers (especially when they have to repack).
ii) Many packages actually automate this step by implementing a "get- orig-source" target in rules which is basically a shell script grabbing the new upstream release, stripping it as appropriate and repacking it. (The upstream version number can be extracted from the changelog with dpkg-parsechangelog.) So you can simply type "fakeroot debian/rules get-orig-source" to prepare a new tarball, and at the same time the exact stripping you applied is documented. iii) Usually, the download URL and optionally the stripping are described in debian/copyright (e.g. "This package was downloaded from http://moblin.org/... and repacked to drop packaging and VCS files"); in Debian this is more strictly enforced than in Ubuntu, but at least if you include a get-orig-source target, this will be documented in debian/rules. b) Concerning the Ubuntu changes in the diff, these are: - patching the README to s/Gutsy/Hardy - not checking for SUDO_USER (libs/mic_cfg.py) as was discussed at the sprint, we're going to move to patches to carry our changes for Hildon modules; I think we should do the same for Moblin modules as well, so it would be nice to split these into two patches; this is completely optional and up to you depending of your time. BTW, the README changes can probably be sent upstream at this point, and I am not sure what the sudo changes are actually achieving -- do you know? c) When closing bugs as a result of a new upstream version, it's good style to list what was fixed in the new upstream version (unless the bug is about the new upstream release itself -- like this bug); this is shortly mentionned in the new maintainers' guide: http://www.debian.org/doc/maint-guide/ch-update.en.html#s-newupstream-real but I usually quote vorlon on this: http://article.gmane.org/gmane.linux.debian.devel.mentors/11053 So it would be nice to reword: * New upstream version (LP: #188130) fixes LP: #151979 and LP: #182169 into e.g.: * New upstream version (LP: #188130) - Remembers customized foobar of baz. (LP: #xxxxxx) In your case however, #151979 looks like a typo and #182169 looks like it's an unrelated to the new upstream release (I think it was fixed by fixing the installability of the fsets). Can you confirm? It would be nice if you could fix c) and a); b) is up to you. The rest is fine; thanks for your work! -- Update moblin-image-creator to 0.40 https://bugs.launchpad.net/bugs/188130 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
