Hi Julien,

I had a look at your debdiff with fresh eyes and noticed some areas
where the packaging could be enhanced a little, but I've decided to
upload the changes nevertheless as it was already quite good.  I'm
listing some suggestions below, you're welcome to fix them in a new
debdiff in this report or open a new report with a new debdiff, but you
don't need to.

a) You change the watch file as follows:
-https://launchpad.net/awn/+download 
https://launchpad.net/awn/*/*/+download/avant-window-navigator-(.*)\.tar\.bz2
+https://launchpad.net/awn/+download 
https://launchpad.net/awn/.*/avant-window-navigator-(.+).tar

presumably upstream had some releases as .tar.bz2 and others as .tar;
perhaps you can simply change the end of the regexp to match both types
of releases?

b) libawn-dev could depend on ${shlibs:Depends}; for example at some
point it might ship binaries which are not linked to the exact same
libraries; it's good practice to list these in all cases and be on the
safe side

c) Not sure you need to honor the Maintainer field spec here as I
couldn't find a corresponding Debian source package; you might simply be
able to take the Maintainer: and forget about XSBC-OriginalMaintainer;
I'm not 100% sure though.

d) "XS-Python-Version: current" isn't terribly supported; you might want
to list a version such as ">= 2.4" and use the matching python dep (e.g.
python (>= 2.4))

e) The python-awn package is arch: any which suggests it builds python
extensions; in this case, you're supposed to change the build to be run
one time per python version (as returned by "pyversions -r") and if you
like one time with the debug python

f) python-awn doesn't "Provides:" ${python:Provides}

g) You might want to fix this lintian warning about the casing of Python:
W: python-awn: spelling-error-in-description python Python


Thanks again for the update!

** Changed in: avant-window-navigator (Ubuntu)
       Status: Confirmed => Fix Committed

-- 
Various fixes in debian dir
https://bugs.launchpad.net/bugs/181635
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to