Hi Gianfranco, I know you are trying to help. Thanks for that.
But this SRU has several issues. a) test plan [ Test Plan ] * Install the library, disable network, get a stacktrace That's not good enough, sorry. Something needs to exercise the library. b) regression analysis That's non-existent: [ Where problem could occur ] * This is an useful fix for Britney in case of network issues c) wrong versions all around python-amqplib | 1.0.2-2 | focal/universe | source python-amqplib | 1.0.2-2ubuntu1.20.04.6 | focal/unapproved/56fd8ef | source python-amqplib | 1.0.2-2 | jammy/universe | source python-amqplib | 1.0.2-2ubuntu1.22.04.5 | jammy/unapproved/ba38eaf | source python-amqplib | 1.0.2-3 | noble/universe | source python-amqplib | 1.0.2-3ubuntu1.22.04.4 | noble/unapproved/26adfca | source That should have been: f: 1.0.2-2ubuntu0.20.04.1 j: 1.0.2-2ubuntu0.22.04.1 n: 1.0.2-3ubuntu0.24.04.1 or 1.0.2-3ubuntu0.1 We won't SRU this to focal, as it's under ESM. c) missing update-maintainer run. d/control still has the debian maintainer listed. d) Patches are missing Origin, Bug references. They have Author, so that's good, but isn't there another source reference? This is not a blocker, though. e) Does the build fail if you don't disable the tests? I checked the existing build logs[1] and I don't see a failure (but I also didn't see tests being executed). 1. https://launchpadlibrarian.net/448494733/buildlog_ubuntu-focal- amd64.python-amqplib_1.0.2-2_BUILDING.txt.gz -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1895893 Title: [SRU] Python 3 variable scoping issue is hiding error tracebacks To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-amqplib/+bug/1895893/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
