** Description changed: + [ SRU Justification ] + + To correctly build on stonking and resolute with kernel version major + than 7.0.12, we need to fix an issue introduced by upstream by removing + a MACRO in kernel. + + [ Current Test Plan ] + + Tested on resolute 7.0.0-22-generic and 7.0.0-28-generic (using kernel 7.0.12) + Tested on stonking 7.0.0-14-generic + + Both distro correctly build the dkms and the modified DKMS can be + loaded. + + [ Possible regression ] + The fix is limited to removing a non existing feature, the only possible regression comes from the fact that some user-space programs may rely on the output of the printk to do some operations and those script might fail from now on. + + Patches will be appended to next messages. + + ====================================================================================================== + The patch successfully builds in kernel 7.0.0-22 and 7.0.0-28 + + ================================ RESOLUTE + Building initial module doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1 for 7.0.0-22-generic + Sign command: /usr/bin/kmodsign + Signing key: /var/lib/shim-signed/mok/MOK.priv + Public certificate (MOK): /var/lib/shim-signed/mok/MOK.der + + Running the pre_build script.................. done. + Building module(s)....................... done. + + Building initial module doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1 for 7.0.0-28-generic + Sign command: /usr/bin/kmodsign + Signing key: /var/lib/shim-signed/mok/MOK.priv + Public certificate (MOK): /var/lib/shim-signed/mok/MOK.der + + Running the pre_build script.................... done. + Building module(s)....................... done. + ===================================================================== + + ====================== STONKING + + Building initial module doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1 for 7.0.0-14-generic + Sign command: /usr/bin/kmodsign + Certificate or key are missing, generating them using update-secureboot-policy... + Secure Boot not enabled on this system. + Signing key: /var/lib/shim-signed/mok/MOK.priv + Public certificate (MOK): /var/lib/shim-signed/mok/MOK.der + + Running the pre_build script..................... done. + Building module(s)........................... done. + + ======================================================================= + + ======================AUTOPKGTEST==================================== + I: Testing if doca-ofed-26.01-dkms modules are correctly installed. + doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1, 7.0.0-22-generic, x86_64: installed (Original modules exist) + doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1/7.0.0-22-generic/x86_64/log/make.log + doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1/7.0.0-3-generic/x86_64/log/make.log + I: Summary: + I: PASS doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1 7.0.0-3-generic + I: PASS doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1 7.0.0-22-generic + PID TTY STAT TIME COMMAND + 72944 hvc1 S+ 0:00 sleep 3 + autopkgtest [14:39:22]: test dkms-autopkgtest: -----------------------] + autopkgtest [14:39:23]: test dkms-autopkgtest: - - - - - - - - - - results - - - - - - - - - - + dkms-autopkgtest PASS (superficial) + autopkgtest [14:39:24]: @@@@@@@@@@@@@@@@@@@@ summary + dkms-autopkgtest PASS (superficial) + qemu-system-x86_64: terminating on signal 15 from pid 1768698 (/usr/bin/python3) + ===================================================================== + + --- + With the following change introduced for 7.0.0-28: - sunrpc: Kill RPC_IFDEBUG() + sunrpc: Kill RPC_IFDEBUG() - BugLink: https://bugs.launchpad.net/bugs/2156385 + BugLink: https://bugs.launchpad.net/bugs/2156385 - [ Upstream commit adcc59114ccd402259c089b0fea24da5e4974563 ] + [ Upstream commit adcc59114ccd402259c089b0fea24da5e4974563 ] - RPC_IFDEBUG() is used in only two places. In one the user of - the definition is guarded by ifdeffery, in the second one - it's implied due to dprintk() usage. Kill the macro and move - the ifdeffery to the regular condition with the variable defined - inside, while in the second case add the same conditional and - move the respective code there. + RPC_IFDEBUG() is used in only two places. In one the user of + the definition is guarded by ifdeffery, in the second one + it's implied due to dprintk() usage. Kill the macro and move + the ifdeffery to the regular condition with the variable defined + inside, while in the second case add the same conditional and + move the respective code there. We are having a build issue for doca-ofed module (https://launchpadlibrarian.net/865905515/buildlog_ubuntu-resolute- amd64.linux-main-modules_7.0.0-28.28_BUILDING.txt.gz). Note this issue is due to code duplication and fix is actually provided in the commit about as well. - make[4]: Entering directory '/<<PKGBUILDDIR>>/staging_dir/linux-main-modules/fake_dkms_root_folder/doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1/build/mlnx-nfsrdma' warning: the compiler differs from the one used to build the kernel - The kernel was built by: x86_64-linux-gnu-gcc (Ubuntu 15.2.0-16ubuntu1) 15.2.0 - You are using: gcc (Ubuntu 15.2.0-16ubuntu1) 15.2.0 + The kernel was built by: x86_64-linux-gnu-gcc (Ubuntu 15.2.0-16ubuntu1) 15.2.0 + You are using: gcc (Ubuntu 15.2.0-16ubuntu1) 15.2.0 warning: pahole version differs from the one used to build the kernel - The kernel was built with: 131 - You are using: 0 - CC [M] transport.o - CC [M] rpc_rdma.o - CC [M] verbs.o - CC [M] frwr_ops.o - CC [M] ib_client.o - CC [M] svc_rdma.o - CC [M] svc_rdma_backchannel.o - CC [M] svc_rdma_transport.o - CC [M] svc_rdma_sendto.o - CC [M] svc_rdma_recvfrom.o + The kernel was built with: 131 + You are using: 0 + CC [M] transport.o + CC [M] rpc_rdma.o + CC [M] verbs.o + CC [M] frwr_ops.o + CC [M] ib_client.o + CC [M] svc_rdma.o + CC [M] svc_rdma_backchannel.o + CC [M] svc_rdma_transport.o + CC [M] svc_rdma_sendto.o + CC [M] svc_rdma_recvfrom.o svc_rdma_transport.c: In function ‘svc_rdma_accept’: svc_rdma_transport.c:489:9: error: implicit declaration of function ‘RPC_IFDEBUG’; did you mean ‘RPCDBG_DEBUG’? [-Wimplicit-function-declaration] - 489 | RPC_IFDEBUG(struct sockaddr *sap); - | ^~~~~~~~~~~ - | RPCDBG_DEBUG + 489 | RPC_IFDEBUG(struct sockaddr *sap); + | ^~~~~~~~~~~ + | RPCDBG_DEBUG svc_rdma_transport.c:489:21: error: expected expression before ‘struct’ - 489 | RPC_IFDEBUG(struct sockaddr *sap); - | ^~~~~~ + 489 | RPC_IFDEBUG(struct sockaddr *sap); + | ^~~~~~ svc_rdma_transport.c:651:9: error: ‘sap’ undeclared (first use in this function); did you mean ‘swap’? - 651 | sap = (struct sockaddr *)&newxprt->sc_cm_id->route.addr.src_addr; - | ^~~ - | swap + 651 | sap = (struct sockaddr *)&newxprt->sc_cm_id->route.addr.src_addr; + | ^~~ + | swap svc_rdma_transport.c:651:9: note: each undeclared identifier is reported only once for each function it appears in make[6]: *** [/usr/src/linux-headers-7.0.0-28-generic/scripts/Makefile.build:289: svc_rdma_transport.o] Error 1 make[6]: *** Waiting for unfinished jobs.... make[5]: *** [/usr/src/linux-headers-7.0.0-28-generic/Makefile:2115: .] Error 2 make[4]: *** [/usr/src/linux-headers-7.0.0-28-generic/Makefile:248: __sub-make] Error 2 make[4]: Leaving directory '/<<PKGBUILDDIR>>/staging_dir/linux-main-modules/fake_dkms_root_folder/doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1/build/mlnx-nfsrdma' make[3]: *** [Makefile:248: __sub-make] Error 2 make[3]: Leaving directory '/usr/src/linux-headers-7.0.0-28-generic' make[2]: *** [makefile:73: default] Error 2 make[2]: Leaving directory '/<<PKGBUILDDIR>>/staging_dir/linux-main-modules/fake_dkms_root_folder/doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1/build/mlnx-nfsrdma'
** Description changed: [ SRU Justification ] To correctly build on stonking and resolute with kernel version major than 7.0.12, we need to fix an issue introduced by upstream by removing a MACRO in kernel. - [ Current Test Plan ] + [ Test Plan ] - Tested on resolute 7.0.0-22-generic and 7.0.0-28-generic (using kernel 7.0.12) - Tested on stonking 7.0.0-14-generic + Test build, installation and load on resolute 7.0.0-22-generic and 7.0.0-28-generic + Test build, installation and load on stonking 7.0.0-14-generic - Both distro correctly build the dkms and the modified DKMS can be - loaded. [ Possible regression ] The fix is limited to removing a non existing feature, the only possible regression comes from the fact that some user-space programs may rely on the output of the printk to do some operations and those script might fail from now on. - - Patches will be appended to next messages. - - ====================================================================================================== - The patch successfully builds in kernel 7.0.0-22 and 7.0.0-28 - - ================================ RESOLUTE - Building initial module doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1 for 7.0.0-22-generic - Sign command: /usr/bin/kmodsign - Signing key: /var/lib/shim-signed/mok/MOK.priv - Public certificate (MOK): /var/lib/shim-signed/mok/MOK.der - - Running the pre_build script.................. done. - Building module(s)....................... done. - - Building initial module doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1 for 7.0.0-28-generic - Sign command: /usr/bin/kmodsign - Signing key: /var/lib/shim-signed/mok/MOK.priv - Public certificate (MOK): /var/lib/shim-signed/mok/MOK.der - - Running the pre_build script.................... done. - Building module(s)....................... done. - ===================================================================== - - ====================== STONKING - - Building initial module doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1 for 7.0.0-14-generic - Sign command: /usr/bin/kmodsign - Certificate or key are missing, generating them using update-secureboot-policy... - Secure Boot not enabled on this system. - Signing key: /var/lib/shim-signed/mok/MOK.priv - Public certificate (MOK): /var/lib/shim-signed/mok/MOK.der - - Running the pre_build script..................... done. - Building module(s)........................... done. - - ======================================================================= - - ======================AUTOPKGTEST==================================== - I: Testing if doca-ofed-26.01-dkms modules are correctly installed. - doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1, 7.0.0-22-generic, x86_64: installed (Original modules exist) - doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1/7.0.0-22-generic/x86_64/log/make.log - doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1/7.0.0-3-generic/x86_64/log/make.log - I: Summary: - I: PASS doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1 7.0.0-3-generic - I: PASS doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1 7.0.0-22-generic - PID TTY STAT TIME COMMAND - 72944 hvc1 S+ 0:00 sleep 3 - autopkgtest [14:39:22]: test dkms-autopkgtest: -----------------------] - autopkgtest [14:39:23]: test dkms-autopkgtest: - - - - - - - - - - results - - - - - - - - - - - dkms-autopkgtest PASS (superficial) - autopkgtest [14:39:24]: @@@@@@@@@@@@@@@@@@@@ summary - dkms-autopkgtest PASS (superficial) - qemu-system-x86_64: terminating on signal 15 from pid 1768698 (/usr/bin/python3) - ===================================================================== --- With the following change introduced for 7.0.0-28: sunrpc: Kill RPC_IFDEBUG() BugLink: https://bugs.launchpad.net/bugs/2156385 [ Upstream commit adcc59114ccd402259c089b0fea24da5e4974563 ] RPC_IFDEBUG() is used in only two places. In one the user of the definition is guarded by ifdeffery, in the second one it's implied due to dprintk() usage. Kill the macro and move the ifdeffery to the regular condition with the variable defined inside, while in the second case add the same conditional and move the respective code there. We are having a build issue for doca-ofed module (https://launchpadlibrarian.net/865905515/buildlog_ubuntu-resolute- amd64.linux-main-modules_7.0.0-28.28_BUILDING.txt.gz). Note this issue is due to code duplication and fix is actually provided in the commit about as well. make[4]: Entering directory '/<<PKGBUILDDIR>>/staging_dir/linux-main-modules/fake_dkms_root_folder/doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1/build/mlnx-nfsrdma' warning: the compiler differs from the one used to build the kernel The kernel was built by: x86_64-linux-gnu-gcc (Ubuntu 15.2.0-16ubuntu1) 15.2.0 You are using: gcc (Ubuntu 15.2.0-16ubuntu1) 15.2.0 warning: pahole version differs from the one used to build the kernel The kernel was built with: 131 You are using: 0 CC [M] transport.o CC [M] rpc_rdma.o CC [M] verbs.o CC [M] frwr_ops.o CC [M] ib_client.o CC [M] svc_rdma.o CC [M] svc_rdma_backchannel.o CC [M] svc_rdma_transport.o CC [M] svc_rdma_sendto.o CC [M] svc_rdma_recvfrom.o svc_rdma_transport.c: In function ‘svc_rdma_accept’: svc_rdma_transport.c:489:9: error: implicit declaration of function ‘RPC_IFDEBUG’; did you mean ‘RPCDBG_DEBUG’? [-Wimplicit-function-declaration] 489 | RPC_IFDEBUG(struct sockaddr *sap); | ^~~~~~~~~~~ | RPCDBG_DEBUG svc_rdma_transport.c:489:21: error: expected expression before ‘struct’ 489 | RPC_IFDEBUG(struct sockaddr *sap); | ^~~~~~ svc_rdma_transport.c:651:9: error: ‘sap’ undeclared (first use in this function); did you mean ‘swap’? 651 | sap = (struct sockaddr *)&newxprt->sc_cm_id->route.addr.src_addr; | ^~~ | swap svc_rdma_transport.c:651:9: note: each undeclared identifier is reported only once for each function it appears in make[6]: *** [/usr/src/linux-headers-7.0.0-28-generic/scripts/Makefile.build:289: svc_rdma_transport.o] Error 1 make[6]: *** Waiting for unfinished jobs.... make[5]: *** [/usr/src/linux-headers-7.0.0-28-generic/Makefile:2115: .] Error 2 make[4]: *** [/usr/src/linux-headers-7.0.0-28-generic/Makefile:248: __sub-make] Error 2 make[4]: Leaving directory '/<<PKGBUILDDIR>>/staging_dir/linux-main-modules/fake_dkms_root_folder/doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1/build/mlnx-nfsrdma' make[3]: *** [Makefile:248: __sub-make] Error 2 make[3]: Leaving directory '/usr/src/linux-headers-7.0.0-28-generic' make[2]: *** [makefile:73: default] Error 2 make[2]: Leaving directory '/<<PKGBUILDDIR>>/staging_dir/linux-main-modules/fake_dkms_root_folder/doca-ofed-26.01-dkms/26.01.1.0.0.0.609.1/build/mlnx-nfsrdma' ** Changed in: doca-ofed-26.01-dkms (Ubuntu Stonking) Status: Fix Committed => In Progress ** Changed in: doca-ofed-26.01-dkms (Ubuntu Resolute) Status: Fix Committed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2157782 Title: doca-ofed-26-01-dkms build failure for resolute 7.0.0-28 lmm To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/doca-ofed-26.01-dkms/+bug/2157782/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
