Hey Alex, Does this only occur when the guest page size is larger?
Your SRU template looks mostly good; your impact section describes the end-user impact, the test plan clearly describes how to reproduce the problem and what we should be looking for in your verification, and you've included the upstream commit hash & links. You are missing a "Where problems could occur" section [1]. If this change (small as it is) were wrong or broken, how would that manifest for a typical user of the package? What kind of risk are we running by making the change for all users of Ubuntu [2]? This change landed upstream very recently. I get no output from `git tag --contains d24cda8a325d`, so this probably hasn't landed in Debian/Ubuntu yet. In order to get this fixed in R/N, you'll need to make sure the fix is present in at least stonking-proposed first (ideally all the way to the release pocket) [3]. There are a couple of ways you could do this; asking upstream when they're planning their next release is probably a reasonable start. On to your debdiffs: Please follow the patterns described in [4] for your version number; we like to include the LP number in test builds (thanks for this BTW!) but not for the final upload. Your changelog entry is pretty good; two nits: - I usually indent sub-bullets two spaces instead of one. - I find that putting the impact first often improves clarity; what about "Fix mounts failing with 'Cannot allocate memory' on guests with larger page sizes than the host"? My [ Impact ] section can also be a helpful guide for writing the changelog entry; what about "Fix directory reads...", since the mount isn't strictly what's broken? Your patches look very good, thanks for including the short buglink in your DEP-3 headers! I personally prefer to review a merge proposal rather than debdiffs; you might consider using the git-buildpackage patch-queue for future SRUs to easily cherry-pick & prevent patch fuzz [5]. Not a problem here though, and I promise not to bother you about it again :) This is really nice work, thanks! [1] https://ubuntu.com/project/docs/SRU/reference/bug-template/#reference-sru-bug-template [2] https://ubuntu.com/project/docs/SRU/explanation/requirements/ [3] https://ubuntu.com/project/docs/SRU/explanation/further-requirements/#development-release-fixed-first [4] https://ubuntu.com/project/docs/how-ubuntu-is-made/concepts/version-strings/ [5] https://honk.sigxcpu.org/projects/git-buildpackage/manual-html/gbp.patches.html -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2155048 Title: [SRU] Backport request - server: do not reject oversized readdir requests To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/rust-virtiofsd/+bug/2155048/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
