Hey Antoine, Thank you very much for the review, I will be checking and addressing/challenging the requests.
Will come back to you. On Fri, Jun 5, 2026 at 12:25 PM Antoine Lassagne <[email protected]> wrote: > > Hello, > > This is my review. I'm following this template [0] > > * debian/changelog: > * You should target Stonking > * You are not packaging the latest upstream version, which is 1.6 (released > on April 27th, you're unlucky :) ) > * debian/watch: > * `uscan` works but `uscan --download-current-version does not work. > This works better (credits to AI ofc): > ``` > version: 5 > > Search-Mode: plain > Source: https://codeberg.org/api/v1/repos/ifreund/waylock/releases > Matching-Pattern: > https://codeberg.org/ifreund/waylock/releases/download/v@ANY_VERSION@/[^"]*@ARCHIVE_EXT@ > Uversionmangle: s/$/+ds/ > Pgp-Sig-Url-Mangle: s%$%.sig% > ``` > * You mention debian/rules get-orig-source in README.source - does not work > either because it relies on uscan - it makes things a little confusing. Can't > we do the repack purely through uscan? Maybe we an MUT like [1]? But also the > reviewing template gives you extra points [0]... At least shouldn't they > behave the same? > * also this get-orig-source is broken. You could also mention that it > requires `tar` and `zig`. > > * Lintian > * The source one you can get rid of are > W: waylock source: build-depends-on-obsolete-package Build-Depends: > pkg-config => pkgcon > I: waylock source: debian-rules-contains-unnecessary-get-orig-source-target > [debian/rules] > I: waylock source: missing-explanation-for-repacked-upstream-tarball > [debian/copyright:1] > * the binary ones are more concerning, please fix them or add overrides > with proper justifications > E: waylock: FSSTND-dir-in-usr [usr/etc/] > E: waylock: description-starts-with-package-name > W: waylock: extended-description-line-too-long line 4 > W: waylock: file-in-unusual-dir [usr/etc/pam.d/waylock] > W: waylock: groff-message error while loading shared libraries: > /usr/lib/x86_64-linux-gnu/libc.so.6: cannot apply additional memory > protection after relocation: Permission denied > [usr/share/man/man1/waylock.1.gz:1] > W: waylock: synopsis-too-long > X: waylock: hardening-no-fortify-functions [usr/bin/waylock] > > * rules > * You can get rid of dh_verbose > > * control > * Section: x11 sounds both right and weird :) > > * d/copyright: lrc is not clean > ISC | Expat > DEBIAN_VENDORED/wayland-0.4.0-lQa1khbMAQAsLS2eBR7M5lofyEGPIbu2iFDmoz8lPC27/LICENSE > ISC | Expat > DEBIAN_VENDORED/xkbcommon-0.3.0-VDqIe3K9AQB2fG5ZeRcMC9i7kfrp5m2rWgLrmdNn9azr/LICENSE > > I hope this helps :) > > [0] https://wiki.ubuntu.com/UbuntuDevelopment/CodeReviews#NewPackage > [1] > https://git.launchpad.net/~antoinelassagne/+git/libnvidia-container/tree/debian/watch > > -- > You received this bug notification because you are subscribed to the bug > report. > https://bugs.launchpad.net/bugs/2143040 > > Title: > [needs-packaging] waylock - A small, secure Wayland screenlocker > > Status in Ubuntu: > In Progress > Status in Debian: > New > > Bug description: > Waylock is a small screenlocker for Wayland compositors implementing > ext-session-lock-v1. The ext-session-lock-v1 protocol is significantly > more robust than previous client-side Wayland screen locking > approaches. Importantly, the screenlocker crashing does not cause the > session to be unlocked. > > The main repository is on codeberg, which is where the issue tracker > may be found and where contributions are accepted. > > Read-only mirrors exist on sourcehut and github. > > [needs-packaging]: > Upstream: https://codeberg.org/ifreund/waylock > License: > https://salsa.debian.org/tchavadar/waylock/-/blob/ubuntu/devel/debian/copyright?ref_type=heads > Packaging Repo URL: https://salsa.debian.org/tchavadar/waylock > PPA: https://launchpad.net/~tchavadar/+archive/ubuntu/river > > To manage notifications about this bug go to: > https://bugs.launchpad.net/ubuntu/+bug/2143040/+subscriptions > -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2143040 Title: [needs-packaging] waylock - A small, secure Wayland screenlocker To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2143040/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
