Hello, I have no upload rights to sponsor this but here is my review: * It's not immediately clear what branch / package you want to get sponsored. I assume this is the package in [0] (the one that you mention users are already using?) and the code from [1]. You should make it more obvious :) You mention other MPs in the `Other Info` section which adds more confusion.
* I believe the version in the changelog should be 1.5-1~24.04.1. According to the documentation [2], it's backported from Ubuntu devel and not from upstream? Or maybe I'm not interpreting the documentation correctly * You d/changelog entry has the wrong week day (yes, lintian checks that :D) * Test plan: * I'm not familiar with Xilinx device, but in step 2 I assume you mean "Install the package on Xilinx target device(s) running noble" * It's also a nitpick since you'll be the one running the test plan, but it helps to add the commands you will run here. It will help near-future-you run the test without requiring too much brain power, and it will help far-future-you understand what went wrong if something goes wrong. * Same thing for step 5 if that's relevant (again, I'm a newbie regarding these machines). [0] https://launchpad.net/~sinan-k/+archive/ubuntu/xlnx-image-update-test [1] https://code.launchpad.net/~limerick-team/ubuntu/+source/xlnx-image-update/+git/xlnx-image-update/+ref/ubuntu/noble-devel [2] https://documentation.ubuntu.com/project/how-ubuntu-is-made/concepts/version-strings/#version-backport-from-ubuntu-devel -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2145545 Title: [SRU] [Noble] Backport xlnx-image-update to noble To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/xlnx-image-update/+bug/2145545/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
