Thanks for the review! I've addressed most of the comments. New PPA: https://launchpad.net/~pushkarnk/+archive/ubuntu/ghostty4 Updated sources: https://code.launchpad.net/~pushkarnk/+git/ghostty
Summary of changes: > Use versioned license, e.g. usr/share/common-licenses/LGPL-2 Done. > Exclude examples from vendored sources Done. > Priority is optional by default we can omit it. It becomes a warning with > Standards Version 4.7.3 Lintian throws a warning if I omit "Priority: Optional" > We can drop windows tests from the vendored sources > We can drop tests from the vendored sources Removed binaries in vendored sources. Retained some generated sources through lintian overrides. Will consider removing them in a future release. > Consider adding debian/upstream/metadata > (https://dep-team.pages.debian.net/deps/dep12/) > Could use source/metadata Added. > nit: consider disabling info level logging: Added a patch to set default logging level to ".warn" > could rename get-orig to get-orig-source for the extra points Renamed. > Some differences reported for vendored code, e.g. GPL-licensed code has MIT > copyright in d/copyright. > See attached lrc.log. Differences sorted. Added lrc.config with suitable comments. Also added some lintian-overrides to keep lrc happy. ----- $ lrc en: Versions: licenserecon '6.0' licensecheck '3.3.9-1ubuntu1' Parsing Source Tree .... Reading d/copyright .... Running licensecheck .... No significant differences found $ lintian --pedantic $ ----- -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2139393 Title: [needs-packaging] ghostty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2139393/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
