Hi Antoine, Nice work! There are a couple things though that need to be done before more formal review =) - we need to package latest upstream vulkan-sdk-1.4.328.1 (unless there is a good reason not to) - version should be 1.4.328.1-0ubuntu1 (since it is Ubuntu first package) - the changelog should be collapsed to a single entry - the changelog should target resolute - we will need to backport/sru the package once it is uploaded - maintainer set to Ubuntu Developers <[email protected]>\ - Vcs-Git: https://salsa.debian.org/xorg-team/vulkan/spirv-reflect.git Vcs-Browser: https://salsa.debian.org/xorg-team/vulkan/spirv-reflect - those should point to launchpad, unless the package is uploaded to Debian/hosted on salsa - Extended description of the source package has too long lines - Extended description of the binary package could use some details (e.g. copy source package description) - We need google test in dependencies to run build-time tests (see https://github.com/KhronosGroup/SPIRV-Reflect/blob/main/.github/workflows/linux-cmake-build.yml) - we need a manual page, it can be created with help2man - lintian reports some warnings: W: libspirv-reflect: extended-description-line-too-long line 3 W: libspirv-reflect: no-manual-page [usr/bin/spirv-reflect-pp] W: libspirv-reflect: no-manual-page [usr/bin/spirv-reflect] P: spirv-reflect source: package-does-not-install-examples [examples/] P: spirv-reflect source: redundant-rules-requires-root-no-field [debian/control:11] P: spirv-reflect source: trailing-whitespace [debian/control:6] - It would be nice to provide autopkgtests - Maybe split into spriv-reflect package with utilities, libspriv-reflect with a library and libspriv-reflect-dev with headers.
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2127243 Title: [needs-packaging] spirv-reflect To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2127243/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
