** Description changed: [ Impact ] - - Some hardware can't properly timestamp packets with the new PTP header version 2.1. This patch introduces a global var ptp_hdr_ver that can be changed externally (using config file) to allow legacy PTP version to be advertised. Forcing 2.1 also breaks interoperability with some older grandmasters which will ignore packets with ptp_minor version set. The patches below add an config option to advertise older protocol - if config option is not selected then no change in header format i.e - no risk of regression. - + if config option is not selected then no change in header format i.e + no risk of regression. [ Test Plan ] - - Step 1: Run the ptp4l command: "sudo ./ptp4l -f configs/gPTP.cfg -i <iface> -l7 -m" on PTP capable ethernet device with default gPTP.cfg. + Step 1: Run the ptp4l command: "sudo ./ptp4l -f configs/gPTP.cfg -i <iface> -l7 -m" on PTP capable ethernet device with default gPTP.cfg. capture PTP frame using tcpdump/tshark on the interface using command "sudo tcpdump/tshark -i eth0 -xxx ether proto 0x88F7" - step 2: check the value in 0xF offset - Value must be "12" as below: + 0x0000: 0180 c200 000e 6805 ca28 bb08 88f7 1212 - 0x0000: 0180 c200 000e 6805 ca28 bb08 88f7 1212 - - Step 3: Add "ptp_minor_version 0" in "configs/gPTP.cfg" and run the commands in "step 1" again and capture the tcpdump/tshark. - + Step 3: Add "ptp_minor_version 0" in "configs/gPTP.cfg" and run the + commands in "step 1" again and capture the tcpdump/tshark. Step 4: heck the value in 0xF offset - Value must be "02" as below - 0x0000: 0180 c200 000e 6805 ca28 bb08 88f7 1202 - + 0x0000: 0180 c200 000e 6805 ca28 bb08 88f7 1202 [ Where problems could occur ] no regression expected as this function does not get enable by default. - once enabled it only change the PTP TX header field. + once enabled it only change the PTP TX header field. [ Other Info ] These patches are already reviewed in linuxptp mailing list and accepted in version 4.2. - [Request description] Upstream has 2 patches from v4.2 to latest and this is missing in v4.0-1ubuntu1 (in noble/ubuntu-24.04). This patch allows backward compatibility between devices with PTP header versions 2.1 & 2.0. Commits are: ============ Commit 1: https://github.com/richardcochran/linuxptp/commit/5eb0aff95300fa9ba836a1a1f471855d1c1b42bd Commit 2: ========== https://github.com/richardcochran/linuxptp/commit/02a13b039d44479ba429c3cc1b75acb8e6da924a Patches attached below.
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2116213 Title: Allow advertisement of legacy PTP 2.0 protocol To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linuxptp/+bug/2116213/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
