Review for Source Package: galera-4
[Summary]
The essence of the review result from the MIR POV
MIR team ACK under the constraint to resolve the below listed
required TODOs and as much as possible having a look at the
recommended TODOs.
This does need a security review, so I'll assign ubuntu-security
List of specific binary packages to be promoted to main: galera-4,
galera-arbitrator-4
Notes:
Required TODOs:
- The embedded asio package should be unbundled if possible and the Ubuntu
version should be used instead for the purpose of maintainability. Can the
submitter please comment on the feasibility of unbundling asio and using the
Ubuntu version instead?
Recommended TODOs:
- The package should get a team bug subscriber before being promoted
[Rationale, Duplication and Ownership]
A team is committed to own long term maintenance of this package - Ubuntu
Server Team suggested in the MIR. Requires subscription before promotion.
The rationale given in the report seems valid and useful for Ubuntu
[Dependencies]
OK:
- no other Dependencies to MIR due to this
- SRCPKG checked with `check-mir`
- all dependencies can be found in `seeded-in-ubuntu` (already in main)
- none of the (potentially auto-generated) dependencies (Depends
and Recommends) that are present after build are not in main
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
more tests now.
Problems: None
[Embedded sources and static linking]
(Rules from MIR reviewer template left in for reference)
RULE: - Embedding a library source increases the maintenance burden of a package
RULE: since that source needs to be maintained separately from the source in
RULE: the Ubuntu archive. If a source embeds another package, in general the
RULE: embedded package should not be used and the packaging should be modified
RULE: to use the Ubuntu archive version. When this is not possible, the
RULE: security team must agree to using the embedded source.
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard
- Does embed asio, a package which is also in Ubuntu and should be used rather
than being embedded in galera-4.
Problems:
- This package embeds asio which is also available in the Ubuntu archive
(https://launchpad.net/ubuntu/+source/asio). When possible, the Ubuntu version
should be used for the purpose of maintainability. If this is not possible, the
Security team will need to comment on the maintainability of this package. Can
the original MIR submitter please comment on the embedded asio package and
whether the Ubuntu version can be used instead?
[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does parse data formats (files [images, video, audio,
xml, json, asn.1], network packets, structures, ...) from
an untrusted source - this package participates in Galera group communication
and parses replication traffic from peers. I feel this should be treated as an
untrusted source and warrants a security review.
- does expose any external endpoint (port/socket/... or similar) - This package
does listen on cluster ports
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates,
signing, ...) - supports TLS and OpenSSL
- this makes appropriate (for its exposure) use of established risk
mitigation features (dropping permissions, using temporary environments,
restricted users/groups, seccomp, systemd isolation features,
apparmor, ...)
Problems:
- This package parses and accepts network input from peers and listens on
cluster ports. This warrants a security review based on the criteria.
[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
- test suite fails will fail the build upon error.
- does have a non-trivial test suite that runs as autopkgtest
- This does not need special HW for build or test
- no new python2 dependency
Problems: None
[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code. Though this is a C++
file,
- debian/watch is present and looks ok (if needed, e.g. non-native)
- Upstream update history is good - commits every few weeks
- Debian/Ubuntu update history is good - updates every few months
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
maintained the package
- no massive Lintian warnings
- debian/rules is rather clean
- It is not on the lto-disabled list
Problems: None
[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (as far as we can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
tests)
- no use of user 'nobody' outside of tests
- no use of setuid / setgid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit or libseed
- not part of the UI for extra checks
- no translation present, but none needed for this case (user visible)?
Problems: None
** Changed in: galera-4 (Ubuntu)
Assignee: Myles Penner (mylesjp) => (unassigned)
** Changed in: galera-4 (Ubuntu)
Assignee: (unassigned) => Ubuntu Security Team (ubuntu-security)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2122096
Title:
[MIR] galera-4
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/galera-4/+bug/2122096/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
