Review for Source Package: user-session-migration [Summary] The essence of the review result from the MIR POV is that this is a well-maintained debian package with good history and generally adheres to the requirements needed for inclusion in Ubuntu Main, with the exception listed below.
MIR team ACK under the constraint to resolve the below listed required TODOs. This does not need a security review. List of specific binary packages to be promoted to main: user-session-migration Notes: Required TODOs: Please either add an autopkgtest to this package or give a justification as to why an autopkgtest is absent as per lines 164-168 in the MIR reporter’s template. https://canonical-ubuntu-project.readthedocs-hosted.com/MIR/mir-reporters-template/#mir-reporters-template [Rationale, Duplication and Ownership] There is no other package in main providing the same functionality. The rationale given in the report seems valid and useful for Ubuntu. [Dependencies] OK: - no other Dependencies to MIR due to this - SRCPKG checked with `check-mir` - all dependencies can be found in `seeded-in-ubuntu` (already in main) - none of the (potentially auto-generated) dependencies (Depends and Recommends) that are present after build are not in main - no -dev/-debug/-doc packages that need exclusion - No dependencies in main that are only superficially tested requiring more tests now. Problems: None [Embedded sources and static linking] OK: - no embedded source present - no static linking - does not have unexpected Built-Using entries OK: - not a go package, no extra constraints to consider in that regard - No vendoring used, all Built-Using are in main - not a rust package, no extra constraints to consider in that regard - Does not include vendored code. Problems: None [Security] OK: - history of CVEs does not look concerning - does not run a daemon as root - does not use webkit1,2 - does not use lib*v8 directly - does not parse data formats (files [images, video, audio, xml, json, asn.1], network packets, structures, ...) from an untrusted source. - does not expose any external endpoint (port/socket/... or similar) - does not process arbitrary web content - does not use centralized online accounts - does not integrate arbitrary javascript into the desktop - does not deal with system authentication (eg, pam), etc) - does not deal with security attestation (secure boot, tpm, signatures) - does not deal with cryptography (en-/decryption, certificates, signing, ...) - this makes appropriate (for its exposure) use of established risk mitigation features (dropping permissions, using temporary environments, restricted users/groups, seccomp, systemd isolation features, apparmor, ...) Problems: None [Common blockers] OK: - does not FTBFS currently - does have a test suite that runs at build time - test suite fails will fail the build upon error. - does not have an autopkgtest - no new python2 dependency Problems: This package has no autopkgtests and the original MIR does not give justification why. Please either add an autopkgtest or give a justification why they are not necessary for this package. [Packaging red flags] OK: - Ubuntu does not carry a delta - symbols tracking not applicable for this kind of code. - debian/watch is not present but also not needed (e.g. native) - Upstream update history is good - updates at least annually - Debian/Ubuntu update history is good - ubuntu is in sync with Debian upstream - the current release is packaged - promoting this does not seem to cause issues for MOTUs that so far maintained the package - no massive Lintian warnings - debian/rules is rather clean - It is not on the lto-disabled list Problems: None [Upstream red flags] OK: - no Errors/warnings during the build - no incautious use of malloc/sprintf (as far as we can check it) - no incautious use of malloc/sprintf (the language has no direct MM) - no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside tests) - no use of user 'nobody' outside of tests - no use of setuid / setgid - no important open bugs (crashers, etc) in Debian or Ubuntu - no dependency on webkit, qtwebkit or libseed - not part of the UI for extra checks - no translation present, but none needed for this case (user visible)? Problems: None ** Changed in: user-session-migration (Ubuntu) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2121566 Title: [MIR] user-session-migration To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/user-session-migration/+bug/2121566/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
