Review for Source Package: rust-threecpio
[Summary]
The essence of the review result from the MIR POV is that this is a
well-constructed rust package with vendored libraries that follows proper
debian packaging guidelines. This package poses little security risk and does
not require a security review. It should get a description of how to refresh
the vendored components before promotion.
MIR team ACK under the constraint to resolve the below listed required TODOs
and as much as possible having a look at the recommended TODOs.
This does not need a security review
List of specific binary packages to be promoted to main: 3cpio
Notes:
Required TODOs: Add a description in debian/README.source of how to refresh
vendored components. The steps were outlined in the initial MIR report but
should also live in the package.
[Rationale, Duplication and Ownership]
There is no other package in main providing the same functionality.
A team is committed to own long term maintenance of this package -
debcrafters-packages
The rationale given in the report seems valid and useful for Ubuntu
[Dependencies]
OK:
- no other Dependencies to MIR due to this
- SRCPKG checked with `check-mir`
- all dependencies can be found in `seeded-in-ubuntu` (already in main)
- none of the (potentially auto-generated) dependencies (Depends
and Recommends) that are present after build are not in main
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
more tests now.
Problems: None
[Embedded sources and static linking]
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries (rust package so vendored
sources OK)
- not a go package, no extra constraints to consider in that regard
- vendoring is used, but the reasoning is sufficiently explained - this is a
rust-based package and the typical Rust-in_ubuntu pattern is followed
- Rust package that has all dependencies vendored. It does neither have
*Built-Using (after build). Nor does the build log indicate built-in sources
that are missed to be reported as Built-Using.
- rust package using dh_cargo (dh ... --buildsystem cargo)
- Includes vendored code, the package does not have documentation on how
to update the code. The MIR refers to cargo vendor debian/rust-vendor
but that should be outlined in the package.
Problems:
- No instructions in the package about refreshing vendored libraries
[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats (files [images, video, audio,
xml, json, asn.1], network packets, structures, ...) from
an untrusted source.
- does not expose any external endpoint (port/socket/... or similar)
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates,
signing, ...)
- this makes appropriate (for its exposure) use of established risk
mitigation features (dropping permissions, using temporary environments,
restricted users/groups, seccomp, systemd isolation features,
apparmor, ...)
Problems: None
[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
- test suite fails will fail the build upon error.
- this package does not have an autopkgtest but that is not a blocker due to
the build-time tests that are enabled by default, and will fail the build when
the tests fail
- This does not need special HW for build or test
- no new python2 dependency
Problems:
- Though not strictly required, autopkgtests are nice to have for gating and
migrations.
[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- debian/watch is present and looks ok (if needed, e.g. non-native)
- Upstream update history is good - almost daily changes
- Debian/Ubuntu update history is good - almost monthly
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
maintained the package
- no massive Lintian warnings
- debian/rules is rather clean
- It is not on the lto-disabled list
Problems: None
[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (as far as we can check it)
- no incautious use of malloc/sprintf (the language has no direct MM)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
tests)
- no use of setuid / setgid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit or libseed
- not part of the UI for extra checks
- no translation present, but none needed for this case (user visible)?
Problems: None
** Changed in: rust-threecpio (Ubuntu)
Assignee: Myles Penner (mylesjp) => (unassigned)
** Changed in: rust-threecpio (Ubuntu)
Status: New => In Progress
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2119257
Title:
[MIR] rust-threecpio
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rust-threecpio/+bug/2119257/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
