Review for Source Package: linkify-it-py
[Summary]
The essence of the review result from the MIR POV is that this is a simple
python package that performs pattern matching for identifying web URLs or email
addresses in plaintext files. This package sits behind the larger
markdown-it-py and while not updated frequently (~annually), issues raised
upstream appear to be addressed in a reasonable amount of time. There is not a
large delta between Debian and Ubuntu. Note that linkify-it-py depends on
uc-micro-py which will also need to be included into main (MIR already in
progress https://bugs.launchpad.net/ubuntu/+source/uc-micro-py/+bug/2112344).
MIR team ACK
This does not need a security review.
List of specific binary packages to be promoted to main: python3-linkify-it
2.0.3-1ubuntu1
Notes:
Required TODOs:
Complete MIR for uc-micro-py. Already in progress as of this writing.
Recommended TODOs:
The package should get a team bug subscriber before being promoted - Debcrafters
[Rationale, Duplication and Ownership]
There is no other package in main providing the same functionality.
A team is committed to own long term maintenance of this package - Debcrafters
The rationale given in the report seems valid and useful for Ubuntu -
Dependency of markdown-it-py, which is a new runtime dependency of netplan.io.
[Dependencies]
linkify-it-py checked with `check-mir` - python3-uc-micro binary and source
package is in universe
none of the (potentially auto-generated) dependencies (Depends and Recommends)
that are present after build are not in main
no -dev/-debug/-doc packages that need exclusion
No dependencies in main that are only superficially tested requiring
more tests now.
Problems:
- uc-micro-py is a binary dependency and will need an MIR to be promoted to
main as mentioned in the initial MIR report - MIR in progress
[Embedded sources and static linking]
OK:
no embedded source present
no static linking
does not have unexpected Built-Using entries
OK:
not a go package, no extra constraints to consider in that regard
No vendoring used, all Built-Using are in main
not a rust package, no extra constraints to consider in that regard
Does not include vendored code
Problems: None
[Security]
OK:
history of CVEs does not look concerning
does not run a daemon as root
does not use webkit1,2
does not use lib*v8 directly
does not parse data formats (files [images, video, audio, xml, json, asn.1],
network packets, structures, ...) from an untrusted source.
does not expose any external endpoint (port/socket/... or similar)
does not process arbitrary web content
does not use centralized online accounts
does not integrate arbitrary javascript into the desktop
does not deal with system authentication (eg, pam), etc)
does not deal with security attestation (secure boot, tpm, signatures)
does not deal with cryptography (en-/decryption, certificates,
signing, ...)
this makes appropriate (for its exposure) use of established risk
mitigation features (dropping permissions, using temporary environments,
restricted users/groups, seccomp, systemd isolation features,
apparmor, ...)
Problems: None
[Common blockers]
OK:
does not FTBFS currently
does have a test suite that runs at build time
- test suite fails will fail the build upon error.
This does not need special HW for build or test
if a non-trivial test on this level does not make sense (the lib alone
is only doing rather simple things), is the overall solution (app+libs)
extensively covered i.e. via end to end autopkgtest? Trivial test suite
included but appropriate for simplicity of package.
no new python2 dependency
Problems: None
[Packaging red flags]
OK:
Ubuntu does carry a delta, but it is reasonable and maintenance under
control - Ubuntu carries the d/tests directory
symbols tracking not applicable for this kind of code.
debian/watch is present and looks ok (if needed, e.g. non-native)
Upstream update history is slow - roughly annually
Debian/Ubuntu update history is slow - on pace with upstream.
the current release is packaged
promoting this does not seem to cause issues for MOTUs that so far maintained
the package
no massive Lintian warnings
debian/rules is rather clean
It is not on the lto-disabled list
Problems: None
[Upstream red flags]
OK:
no Errors/warnings during the build - one linting warning that is addressed in
the bug report
no incautious use of malloc/sprintf (the language has no direct MM)
no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside tests)
no use of user 'nobody' outside of tests
no use of setuid / setgid
use of setuid, but ok because TBD (prefer systemd to set those for services)
no important open bugs (crashers, etc) in Debian or Ubuntu
no dependency on webkit, qtwebkit or libseed
not part of the UI for extra checks
no translation present, but none needed for this case (user visible)?
Problems: None
** Changed in: linkify-it-py (Ubuntu)
Assignee: Myles Penner (mylesjp) => (unassigned)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2112343
Title:
[MIR] linkify-it-py
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linkify-it-py/+bug/2112343/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
