Performing verification for jammy. I installed cifs-utils 2:6.14-1ubuntu0.2 from jammy -updates.
I followed the testcase and installed valgrind and moved the wrapper script into place: ubuntu@jammy-dc:~$ sudo mv /usr/sbin/cifs.upcall /usr/sbin/cifs.upcall.bin ubuntu@jammy-dc:~$ sudo cp /usr/sbin/cifs.upcall.wrapper /usr/sbin/cifs.upcall ubuntu@jammy-dc:~$ kdestroy kdestroy: No credentials cache found while destroying cache ubuntu@jammy-dc:~$ klist klist: No credentials cache found (filename: /tmp/krb5cc_1000) ubuntu@jammy-dc:~$ sudo mount -t cifs -o sec=krb5i //samba-dc.example.com/demo /mnt/testshare1 mount error(126): Required key not available Refer to the mount.cifs(8) manual page (e.g. man mount.cifs) and kernel log messages (dmesg) ubuntu@jammy-dc:~$ cat valgrind.log ==1618== Memcheck, a memory error detector ==1618== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al. ==1618== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info ==1618== Command: /usr/sbin/cifs.upcall.bin 403655015 ==1618== ==1619== ==1619== HEAP SUMMARY: ==1619== in use at exit: 129 bytes in 1 blocks ==1619== total heap usage: 33 allocs, 32 frees, 83,550 bytes allocated ==1619== ==1619== LEAK SUMMARY: ==1619== definitely lost: 0 bytes in 0 blocks ==1619== indirectly lost: 0 bytes in 0 blocks ==1619== possibly lost: 0 bytes in 0 blocks ==1619== still reachable: 129 bytes in 1 blocks ==1619== suppressed: 0 bytes in 0 blocks ==1619== Rerun with --leak-check=full to see details of leaked memory ==1619== ==1619== For lists of detected and suppressed errors, rerun with: -s ==1619== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0) ==1618== ==1618== HEAP SUMMARY: ==1618== in use at exit: 3,369 bytes in 9 blocks ==1618== total heap usage: 537 allocs, 528 frees, 368,178 bytes allocated ==1618== ==1618== LEAK SUMMARY: ==1618== definitely lost: 56 bytes in 1 blocks ==1618== indirectly lost: 0 bytes in 0 blocks ==1618== possibly lost: 0 bytes in 0 blocks ==1618== still reachable: 3,313 bytes in 8 blocks ==1618== suppressed: 0 bytes in 0 blocks ==1618== Rerun with --leak-check=full to see details of leaked memory ==1618== ==1618== For lists of detected and suppressed errors, rerun with: -s ==1618== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0) ==1618== could not unlink /tmp/vgdb-pipe-from-vgdb-to-1618-by-???-on-??? ==1618== could not unlink /tmp/vgdb-pipe-to-vgdb-from-1618-by-???-on-??? ==1618== could not unlink /tmp/vgdb-pipe-shared-mem-vgdb-1618-by-???-on-??? We leaked 56 bytes of memory. I then enabled -security-proposed by this ppa: https://launchpad.net/~ubuntu-security- proposed/+archive/ubuntu/ppa/+packages?field.name_filter=cifs- utils&field.status_filter=published&field.series_filter= I installed cifs-utils 2:6.14-1ubuntu0.3. I then again moved the valgrind wrapper script into place: ubuntu@jammy-dc:~$ sudo mv /usr/sbin/cifs.upcall /usr/sbin/cifs.upcall.bin ubuntu@jammy-dc:~$ sudo cp /usr/sbin/cifs.upcall.wrapper /usr/sbin/cifs.upcall ubuntu@jammy-dc:~$ kdestroy kdestroy: No credentials cache found while destroying cache ubuntu@jammy-dc:~$ klist klist: No credentials cache found (filename: /tmp/krb5cc_1000) ubuntu@jammy-dc:~$ sudo mount -t cifs -o sec=krb5i //samba-dc.example.com/demo /mnt/testshare1 mount error(126): Required key not available Refer to the mount.cifs(8) manual page (e.g. man mount.cifs) and kernel log messages (dmesg) ubuntu@jammy-dc:~$ cat valgrind.log ==2334== Memcheck, a memory error detector ==2334== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al. ==2334== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info ==2334== Command: /usr/sbin/cifs.upcall.bin 520370035 ==2334== ==2335== ==2335== HEAP SUMMARY: ==2335== in use at exit: 129 bytes in 1 blocks ==2335== total heap usage: 33 allocs, 32 frees, 83,550 bytes allocated ==2335== ==2335== LEAK SUMMARY: ==2335== definitely lost: 0 bytes in 0 blocks ==2335== indirectly lost: 0 bytes in 0 blocks ==2335== possibly lost: 0 bytes in 0 blocks ==2335== still reachable: 129 bytes in 1 blocks ==2335== suppressed: 0 bytes in 0 blocks ==2335== Rerun with --leak-check=full to see details of leaked memory ==2335== ==2335== For lists of detected and suppressed errors, rerun with: -s ==2335== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0) ==2334== ==2334== HEAP SUMMARY: ==2334== in use at exit: 3,313 bytes in 8 blocks ==2334== total heap usage: 538 allocs, 530 frees, 372,293 bytes allocated ==2334== ==2334== LEAK SUMMARY: ==2334== definitely lost: 0 bytes in 0 blocks ==2334== indirectly lost: 0 bytes in 0 blocks ==2334== possibly lost: 0 bytes in 0 blocks ==2334== still reachable: 3,313 bytes in 8 blocks ==2334== suppressed: 0 bytes in 0 blocks ==2334== Rerun with --leak-check=full to see details of leaked memory ==2334== ==2334== For lists of detected and suppressed errors, rerun with: -s ==2334== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0) ==2334== could not unlink /tmp/vgdb-pipe-from-vgdb-to-2334-by-???-on-??? ==2334== could not unlink /tmp/vgdb-pipe-to-vgdb-from-2334-by-???-on-??? ==2334== could not unlink /tmp/vgdb-pipe-shared-mem-vgdb-2334-by-???-on-??? This time we don't leak any memory. Now I am just running through the testcase of bug 2099917: root@jammy-dc:/home/ubuntu# kinit [email protected] Password for [email protected]: Warning: Your password will expire in 39 days on Fri Jul 25 02:42:43 2025 root@jammy-dc:/home/ubuntu# klist Ticket cache: FILE:/tmp/krb5cc_0 Default principal: [email protected] Valid starting Expires Service principal 06/16/25 02:03:14 06/16/25 12:03:14 krbtgt/[email protected] renew until 06/17/25 02:03:11 root@jammy-dc:/home/ubuntu# mount -t cifs -o cruid=root,user=root,sec=krb5i,uid=0,gid=0,cred=/tmp/krb5cc_0 //samba-dc.example.com/demo /mnt/testshare1 root@jammy-dc:/home/ubuntu# umount /mnt/testshare1 root@jammy-dc:/home/ubuntu# git clone https://git.nullroute.lt/hacks/python-krb5ccparse.git Cloning into 'python-krb5ccparse'... remote: Enumerating objects: 59, done. remote: Counting objects: 100% (59/59), done. remote: Compressing objects: 100% (59/59), done. remote: Total 59 (delta 28), reused 0 (delta 0), pack-reused 0 (from 0) Receiving objects: 100% (59/59), 11.55 KiB | 985.00 KiB/s, done. Resolving deltas: 100% (28/28), done. root@jammy-dc:/home/ubuntu# cd python-krb5ccparse/ root@jammy-dc:/home/ubuntu/python-krb5ccparse# ./kremovetkt -c /tmp/krb5cc_0 -o /tmp/removed -p krbtgt/[email protected] Skipping ticket for krbtgt/[email protected] Keeping ticket for krb5_ccache_conf_data/pa_type/krbtgt/[email protected]@X-CACHECONF: Keeping ticket for cifs/samba-dc.example.com@ root@jammy-dc:/home/ubuntu/python-krb5ccparse# kdestroy root@jammy-dc:/home/ubuntu/python-krb5ccparse# mv /tmp/removed /tmp/krb5cc_0 root@jammy-dc:/home/ubuntu/python-krb5ccparse# klist Ticket cache: FILE:/tmp/krb5cc_0 Default principal: [email protected] Valid starting Expires Service principal 06/16/25 02:03:24 06/16/25 12:03:14 cifs/samba-dc.example.com@ renew until 06/17/25 02:03:11 Ticket server: cifs/[email protected] root@jammy-dc:/home/ubuntu/python-krb5ccparse# mount -t cifs -o cruid=root,user=root,sec=krb5i,uid=0,gid=0,cred=/tmp/krb5cc_0 //samba-dc.example.com/demo /mnt/testshare1 root@jammy-dc:/home/ubuntu/python-krb5ccparse# mount -l ... //samba-dc.example.com/demo on /mnt/testshare1 type cifs (rw,relatime,vers=3.1.1,sec=krb5i,cruid=0,cache=strict,username=root,uid=0,forceuid,gid=0,forcegid,addr=192.168.122.79,file_mode=0755,dir_mode=0755,soft,nounix,serverino,mapposix,rsize=4194304,wsize=4194304,bsize=1048576,echo_interval=60,actimeo=1,closetimeo=1,user=root) /var/lib/snapd/snaps/core20_2599.snap on /snap/core20/2599 type squashfs (ro,nodev,relatime,errors=continue,x-gdu.hide) The testcase still holds, and the new package doesn't introduce any regressions. The package in -security-proposed fixes the issue. Happy to mark verified for jammy. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2113906 Title: Regression: After LP2099917 cifs.upcall leaks memory on error message if service ticket doesn't exist To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cifs-utils/+bug/2113906/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
